Skip to content

[Alerting v2] Fix rule preview error in alerting_v2 due to missing EUI theme context #261476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benakansara merged 1 commit into from
Apr 7, 2026
Merged

[Alerting v2] Fix rule preview error in alerting_v2 due to missing EUI theme context #261476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 31 additions & 23 deletions x-pack/platform/plugins/shared/alerting_v2/public/application/mount.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import React from 'react';
import ReactDOM from 'react-dom';
import type { Container } from 'inversify';
import type { AppMountParameters, AppUnmount } from '@kbn/core-application-browser';
import type { ChromeBreadcrumb } from '@kbn/core/public';
import type { ChromeBreadcrumb, CoreStart } from '@kbn/core/public';
import { Context } from '@kbn/core-di-browser';
import { Router } from '@kbn/shared-ux-router';
import { I18nProvider } from '@kbn/i18n-react';
Expand All @@ -27,26 +27,30 @@ interface AlertingV2MountParams {
export const mountAlertingV2App = ({
params,
container,
coreStart,
}: {
params: AlertingV2MountParams;
container: Container;
coreStart: CoreStart;
}): AppUnmount => {
const { element, history, setBreadcrumbs } = params;

const queryClient = new QueryClient();

ReactDOM.render(
<Context.Provider value={container}>
<QueryClientProvider client={queryClient}>
<BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>
<I18nProvider>
<Router history={history}>
<RulesApp />
</Router>
</I18nProvider>
</BreadcrumbProvider>
</QueryClientProvider>
</Context.Provider>,
coreStart.rendering.addContext(
<Context.Provider value={container}>
<QueryClientProvider client={queryClient}>
<BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>
<I18nProvider>
<Router history={history}>
<RulesApp />
</Router>
</I18nProvider>
</BreadcrumbProvider>
</QueryClientProvider>
</Context.Provider>
),
element
);

Expand All @@ -56,26 +60,30 @@ export const mountAlertingV2App = ({
export const mountNotificationPoliciesApp = ({
params,
container,
coreStart,
}: {
params: AlertingV2MountParams;
container: Container;
coreStart: CoreStart;
}): AppUnmount => {
const { element, history, setBreadcrumbs } = params;

const queryClient = new QueryClient();

ReactDOM.render(
<Context.Provider value={container}>
<QueryClientProvider client={queryClient}>
<BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>
<I18nProvider>
<Router history={history}>
<NotificationPoliciesApp />
</Router>
</I18nProvider>
</BreadcrumbProvider>
</QueryClientProvider>
</Context.Provider>,
coreStart.rendering.addContext(
<Context.Provider value={container}>
<QueryClientProvider client={queryClient}>
<BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>
<I18nProvider>
<Router history={history}>
<NotificationPoliciesApp />
</Router>
</I18nProvider>
</BreadcrumbProvider>
</QueryClientProvider>
</Context.Provider>
),
element
);

Expand Down
7 changes: 6 additions & 1 deletion x-pack/platform/plugins/shared/alerting_v2/public/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ export const module = new ContainerModule(({ bind }) => {
async mount(params) {
const [coreStart] = await getStartServices();
const { mountAlertingV2App } = await import('./application/mount');
return mountAlertingV2App({ params, container: coreStart.injection.getContainer() });
return mountAlertingV2App({
params,
container: coreStart.injection.getContainer(),
coreStart,
});
},
});

Expand All @@ -78,6 +82,7 @@ export const module = new ContainerModule(({ bind }) => {
return mountNotificationPoliciesApp({
params,
container: coreStart.injection.getContainer(),
coreStart,
});
},
});
Expand Down
Loading