chore(core): Cover font construction with unit (snapshot) tests#262103
Merged
awahab07 merged 1 commit intoApr 10, 2026
Merged
Conversation
awahab07
added
chore
Team:Core
Contributor
|
Pinging @elastic/kibana-core (Team:Core) |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History |
dokmic
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small follow-up to #251576 to add missing unit coverage for
src/core/packages/rendering/server-internal/src/views/fonts.tsx.The new test verifies the generated
@font-faceCSS handles optional declarations correctly:Elastic UI Numericemits bothfont-displayandunicode-rangeInteromits optional declarations when they are not configuredRoboto Monoemitsunicode-rangewithoutfont-display