[Agent Builder] get rid of the answering step#266319
Closed
pgayvallet wants to merge 21 commits into
Closed
Conversation
…tured response processing
pgayvallet
changed the title
pgayvallet
added
release_note:skip
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
pgayvallet
commented
May 20, 2026
| logger: input.logger, | ||
| sendEvent: this.eventEmitter, | ||
| toolId: toolIdMapping.get(tool.id), | ||
| addReasoningParam: false, |
Contributor
Author
There was a problem hiding this comment.
"Encouraging" LLMs to respond with text in addition to tool call by also removing the "reasoning" tool param we were adding previously. (that reasoning param to tool can't be streamed given we create an event based on the tool call parameters)
If really that's worse and we prefer keeping it, we'll revisit later, it's a 4 char change
joemcelroy
approved these changes
May 20, 2026
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Page load bundle
History
|
Contributor
Contributor
Author
|
merged via #271849 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix https://github.com/elastic/search-team/issues/14204
Related to https://github.com/elastic/search-team/issues/14511
This PR get rid of the agent's dedicated answering step, to get back to a more traditional "single loop" pattern.
Note that the PR depends on FE work, as we are now also sending chunks for intermediate text responses ("reasoning") and the UI needs to be adapted for it to not impact the user experience.
answeragent step (only keep thestructured_outputversion)