[EDR Workflows][Trusted Devices] Allow user to add multiple conditions in trusted devices form#268011
[EDR Workflows][Trusted Devices] Allow user to add multiple conditions in trusted devices form#268011parkiino wants to merge 28 commits into
Conversation
parkiino
added
release_note:enhancement
Team:Defend Workflows
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
elastic-vault-github-plugin-prod
Bot
requested a review
from a team
as a code owner
…kibana into task/trusted-devices-ui-update
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
nice work! 🚀 here are some small findings
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
Did only a code review. Left a few comments that I'm sure you will address, so I'm 👍 it
| return allFields; | ||
| }; | ||
|
|
||
| const OPERATOR_OPTIONS = [ |
There was a problem hiding this comment.
You have a few module level const on this file that are mutable. I would suggest you make them immutable or set the types to be Readonly<> to prevent accidental mutation.
There was a problem hiding this comment.
The type expected on the component that uses those consts actually expect a mutable type
| <EuiFlexItem> | ||
| <EuiFormRow label={showLabels ? 'Value' : undefined}> | ||
| <EuiComboBox | ||
| placeholder="Enter or select value" |
| </EuiFlexItem> | ||
| <EuiFlexItem grow={false}> | ||
| {/* Unicode nbsp so the button aligns with other fields when labels are shown */} | ||
| <EuiFormRow label={showLabels ? '\u00A0' : undefined}> |
There was a problem hiding this comment.
Hmmm. Using a space for alignment is not ideal. Perhaps you need to have your button be "flush" (if it supports that)?
| EuiTextArea, | ||
| EuiTitle, | ||
| } from '@elastic/eui'; | ||
| import styled from 'styled-components'; |
There was a problem hiding this comment.
You should use @emotion/styled instead. styled-component is something we are moving away from
gergoabraham
left a comment
gergoabraham
left a comment
There was a problem hiding this comment.
looks and works well! 🚀 thanks for the updates
…kibana into task/trusted-devices-ui-update
sukhwindersingh-qasource
added
the
ci:cloud-persist-deployment
|
/ci |
…kibana into task/trusted-devices-ui-update
|
/ci |
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
6 participants
Summary
Screenshots
New AND button
Adding multiple conditions
Duplicate fields error
Updated trusted devices card with multiple conditions