Skip to content

[EDR Workflows] Speed up MS Defender runscript Jest tests by mocking p-retry #268311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
szwarckonrad merged 4 commits into from
May 11, 2026
Merged

[EDR Workflows] Speed up MS Defender runscript Jest tests by mocking p-retry #268311

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2944e34
[EDR Workflows] Speed up MS Defender runscript Jest tests by mocking …
szwarckonrad May 7, 2026
705ed42
Merge branch 'main' into fix-ms-defender-runscript-slow-tests
szwarckonrad May 8, 2026
69f4c09
Merge branch 'main' into fix-ms-defender-runscript-slow-tests
szwarckonrad May 11, 2026
d9c7c98
Merge branch 'main' into fix-ms-defender-runscript-slow-tests
szwarckonrad May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions ...s/actions/clients/microsoft/defender/endpoint/ms_defender_endpoint_actions_client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
*/

import { Readable } from 'stream';
import pRetry from 'p-retry';
import { MicrosoftDefenderEndpointActionsClient } from './ms_defender_endpoint_actions_client';
import type { ProcessPendingActionsMethodOptions, ResponseActionsClient } from '../../../../..';
import { getActionDetailsById as _getActionDetailsById } from '../../../../action_details_by_id';
Expand Down Expand Up @@ -46,7 +47,13 @@ jest.mock('../../../../action_details_by_id', () => {
};
});

jest.mock('p-retry', () => {
const originalPRetry = jest.requireActual('p-retry');
return jest.fn().mockImplementation((fn, options) => originalPRetry(fn, options));
});

const getActionDetailsByIdMock = _getActionDetailsById as jest.Mock;
const pRetryMock = jest.mocked(pRetry);

describe('MS Defender response actions client', () => {
let clientConstructorOptionsMock: MicrosoftDefenderActionsClientOptionsMock;
Expand Down Expand Up @@ -603,7 +610,6 @@ describe('MS Defender response actions client', () => {
});
});

// TODO: Fix this slow test
it('should throw error when GET_ACTIONS returns no action details after retry', async () => {
const underlyingClient = (
connectorActionsMock as unknown as { connectorsClient: { execute: jest.Mock } }
Expand All @@ -630,6 +636,8 @@ describe('MS Defender response actions client', () => {
}
);

pRetryMock.mockImplementationOnce(async (fn) => fn(1));

await expect(
msClientMock.runscript(
responseActionsClientMock.createRunScriptOptions({
Expand All @@ -642,7 +650,6 @@ describe('MS Defender response actions client', () => {
});
});

// TODO: Fix this slow test
it('should throw error when GET_ACTIONS call fails', async () => {
const underlyingClient = (
connectorActionsMock as unknown as { connectorsClient: { execute: jest.Mock } }
Expand All @@ -664,6 +671,8 @@ describe('MS Defender response actions client', () => {
}
);

pRetryMock.mockImplementationOnce(async (fn) => fn(1));

await expect(
msClientMock.runscript(
responseActionsClientMock.createRunScriptOptions({
Expand Down
Loading