Skip to content

[ci] Only use cached es snapshot on pull requests #268315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbudz merged 2 commits into from
May 8, 2026
Merged

[ci] Only use cached es snapshot on pull requests #268315

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee3ebf3
[ci] Only use cached es snapshot on pull requests
jbudz May 7, 2026
6a6f89e
reset env
jbudz May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .buildkite/pipelines/pull_request/base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
env:
KBN_ES_SNAPSHOT_USE_CACHED: 'true'

steps:
- command: .buildkite/scripts/steps/build_kibana.sh
label: Build Kibana Distribution
Expand Down
6 changes: 5 additions & 1 deletion src/platform/packages/shared/kbn-es/src/artifact.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,11 @@ const createCachedArtifact = ({ contents, etag = 'etag' }) => {
};

const previousEnvVars = {};
const ENV_VARS_TO_RESET = ['ES_SNAPSHOT_MANIFEST', 'KBN_ES_SNAPSHOT_USE_UNVERIFIED'];
const ENV_VARS_TO_RESET = [
'ES_SNAPSHOT_MANIFEST',
'KBN_ES_SNAPSHOT_USE_UNVERIFIED',
'KBN_ES_SNAPSHOT_USE_CACHED',
];

beforeAll(() => {
ENV_VARS_TO_RESET.forEach((key) => {
Expand Down
2 changes: 1 addition & 1 deletion src/platform/packages/shared/kbn-es/src/artifact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ export class Artifact {
const cacheMeta = cache.readMeta(dest);
const tmpPath = `${dest}.tmp`;

if (useCached) {
if (useCached || process.env.KBN_ES_SNAPSHOT_USE_CACHED === 'true') {
if (cacheMeta.exists) {
this.log.info(
'use-cached passed, forcing to use existing snapshot',
Expand Down
Loading