[9.3] Extend selective testing with implicit consumers (#268256)#268380
Merged
Conversation
## Summary
Some plugins use registries to inject functionality. Both our strategies
for detecting affected modules cannot discover it, because they rely on
static dependencies. We need a better way to handle it.
While we discuss a general solution, this PR serves as a quick fix that
validates potential implicit consumers on top of computed affected
packages and extends "affected modules" if code changes match any of
these patterns:
```
'**/plugins/**/public/embeddables/**/*.{ts,tsx}',
'**/plugins/**/public/embeddable/**/*.{ts,tsx}',
'**/plugins/**/public/react_embeddable/**/*.{ts,tsx}',
'**/plugins/**/public/apps/embeddables/**/*.{ts,tsx}',
'**/plugins/**/public/ui_actions/**/*.{ts,tsx}',
'**/plugins/**/public/trigger_actions/**/*.{ts,tsx}',
'**/plugins/**/public/**/actions/register*.{ts,tsx}',
```
Example:
Changing
`x-pack/platform/plugins/shared/ml/public/embeddables/anomaly_charts/anomaly_charts_embeddable_factory.tsx`
should trigger Scout tests in `dashboard`, `lens`, `canvas` and
`embeddable` plugins
<img width="1954" height="279" alt="Screenshot 2026-05-07 at 19 10 42"
src="https://github.com/user-attachments/assets/6c0b4163-481b-4f34-84b2-290ab3091d96"
/>
(cherry picked from commit 86477a0)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
💚 Build Succeeded
Metrics [docs]
cc @dmlemeshko |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.3:Questions ?
Please refer to the Backport tool documentation