-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Agent Builder] Add new property to public events contract to filter events by conversation id #268440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
chrisbmar
merged 4 commits into
elastic:main
from
chrisbmar:ab-expose-stream-events-public-contract-14381
May 11, 2026
Merged
[Agent Builder] Add new property to public events contract to filter events by conversation id #268440
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
x-pack/platform/plugins/shared/agent_builder/public/services/events/events_service.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { ChatEventType, type ChatEvent } from '@kbn/agent-builder-common'; | ||
| import { EventsService } from './events_service'; | ||
|
|
||
| const messageChunkEvent = (chunk: string): ChatEvent => | ||
| ({ | ||
| type: ChatEventType.messageChunk, | ||
| data: { message_id: 'm1', text_chunk: chunk }, | ||
| } as ChatEvent); | ||
|
|
||
| describe('EventsService', () => { | ||
| describe('getChatEvents$', () => { | ||
| it('only emits events tagged with the matching conversation id', () => { | ||
| const service = new EventsService(); | ||
| const fromA: ChatEvent[] = []; | ||
| const fromB: ChatEvent[] = []; | ||
|
|
||
| service.getChatEvents$('A').subscribe((event) => fromA.push(event)); | ||
| service.getChatEvents$('B').subscribe((event) => fromB.push(event)); | ||
|
|
||
| service.propagateChatEvent('A', messageChunkEvent('a1')); | ||
| service.propagateChatEvent('B', messageChunkEvent('b1')); | ||
| service.propagateChatEvent('A', messageChunkEvent('a2')); | ||
|
|
||
| expect(fromA.map((e) => (e.data as any).text_chunk)).toEqual(['a1', 'a2']); | ||
| expect(fromB.map((e) => (e.data as any).text_chunk)).toEqual(['b1']); | ||
| }); | ||
|
|
||
| it('returns a hot stream — events emitted before subscription are not replayed', () => { | ||
| const service = new EventsService(); | ||
| service.propagateChatEvent('A', messageChunkEvent('missed')); | ||
|
|
||
| const received: ChatEvent[] = []; | ||
| service.getChatEvents$('A').subscribe((event) => received.push(event)); | ||
|
|
||
| service.propagateChatEvent('A', messageChunkEvent('seen')); | ||
|
|
||
| expect(received.map((e) => (e.data as any).text_chunk)).toEqual(['seen']); | ||
| }); | ||
| }); | ||
|
|
||
| describe('obs$ (deprecated)', () => { | ||
| it('still emits every event regardless of conversation id', () => { | ||
| const service = new EventsService(); | ||
| const received: ChatEvent[] = []; | ||
|
|
||
| service.obs$.subscribe((event) => received.push(event)); | ||
|
|
||
| service.propagateChatEvent('A', messageChunkEvent('a')); | ||
| service.propagateChatEvent('B', messageChunkEvent('b')); | ||
|
|
||
| expect(received.map((e) => (e.data as any).text_chunk)).toEqual(['a', 'b']); | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.