Upgrade EUI to v116.1.0

package.json

@@ -145,7 +145,7 @@
     "@elastic/elasticsearch": "9.4.0",
     "@elastic/ems-client": "8.7.0",
     "@elastic/esql": "4.1.0",
-    "@elastic/eui": "116.0.0",
+    "@elastic/eui": "116.1.0",
     "@elastic/eui-theme-borealis": "8.0.0",
     "@elastic/filesaver": "1.1.2",
     "@elastic/kibana-d3-color": "npm:@elastic/kibana-d3-color@2.0.1",
@@ -1606,7 +1606,7 @@
     "@cypress/debugging-proxy": "2.0.1",
     "@cypress/grep": "5.1.0",
     "@cypress/webpack-preprocessor": "6.0.2",
-    "@elastic/eslint-plugin-eui": "2.12.0",
+    "@elastic/eslint-plugin-eui": "2.13.0",
     "@elastic/makelogs": "6.1.1",
     "@emotion/babel-preset-css-prop": "11.11.0",
     "@emotion/jest": "11.11.0",

src/platform/packages/private/kbn-ui-shared-deps-npm/version_dependencies.txt

@@ -18,7 +18,7 @@
 @elastic/esql@4.1.0
 @elastic/eui-theme-borealis@8.0.0
 @elastic/eui-theme-common@10.0.0
-@elastic/eui@116.0.0
+@elastic/eui@116.1.0
 @elastic/numeral@2.5.1
 @elastic/prismjs-esql@1.1.2
 @emotion/babel-plugin@11.13.5

src/platform/packages/shared/cloud/connection_details/components/spa_no_router_link/spa_no_router_link.tsx

@@ -26,7 +26,6 @@ export const SpaNoRouterLink: React.FC<React.PropsWithChildren<SpaNoRouterLinkPr
   ...rest
 }) => {
   return (
-    /* eslint-disable-next-line @elastic/eui/href-or-on-click */
     <EuiLink
       {...rest}
       href={url}

src/platform/packages/shared/cloud/connection_details/connection_details_flyout_content.tsx

@@ -43,7 +43,7 @@ export const ConnectionDetailsFlyoutContent: React.FC<{ headerId?: string }> = (
           {!!ctx.links?.learnMore && (
             // Below onClick is used only for telemetry, but `href` is the real
             // semantic action.
-            // eslint-disable-next-line @elastic/eui/href-or-on-click
+
             <EuiLink
               external
               href={ctx.links.learnMore}

src/platform/packages/shared/content-management/content_list/kbn-content-list-table/src/column/name/cell_title.tsx

@@ -55,7 +55,6 @@ export const NameCellTitle = ({ item, shouldUseHref, onClick }: NameCellTitlePro
 
   return (
     <EuiText size="s">
-      {/* eslint-disable-next-line @elastic/eui/href-or-on-click -- Intentional when `shouldUseHref` preserves native link affordances while `onClick` handles plain clicks. */}
       <EuiLink href={href} onClick={handleClick} data-test-subj="content-list-table-item-link">
         {title}
       </EuiLink>

src/platform/packages/shared/content-management/table_list_view_table/src/components/item_details.tsx

@@ -75,7 +75,6 @@ export function ItemDetails<T extends UserContentCommonSchema>({
 
     return (
       <>
-        {/* eslint-disable-next-line  @elastic/eui/href-or-on-click */}
         <EuiLink
           href={getDetailViewLink?.(item)}
           onClick={onClickTitleHandler}

src/platform/plugins/shared/data/public/search/session/sessions_mgmt/components/table/columns/name.tsx

@@ -46,7 +46,6 @@ const NameColumnText = ({
     );
 
   return (
-    // eslint-disable-next-line @elastic/eui/href-or-on-click
     <EuiLink href={href} onClick={onClick} data-test-subj="sessionManagementNameLink">
       {children}
     </EuiLink>

src/platform/plugins/shared/telemetry/public/components/opt_in_message.tsx

@@ -53,7 +53,6 @@ export const OptInMessage: React.FC<OptInMessageProps> = ({
             </strong>
           ),
           privacyStatementLink: (
-            /* eslint-disable-next-line @elastic/eui/href-or-on-click */
             <EuiLink
               onClick={(e: React.MouseEvent) => {
                 if (hasActiveModifierKey(e)) return;
@@ -99,7 +98,6 @@ function renderTelemetryEnabledOrDisabledText(
   );
 
   return (
-    /* eslint-disable-next-line @elastic/eui/href-or-on-click */
     <EuiLink
       href={addBasePath(PATH_TO_ADVANCED_SETTINGS)}
       onClick={(e: React.MouseEvent) => {

src/platform/plugins/shared/workflows_management/public/features/workflow_execution_detail/ui/workflow_step_execution_details.tsx

@@ -220,7 +220,6 @@ export const WorkflowStepExecutionDetails = React.memo<WorkflowStepExecutionDeta
                 <EuiFlexItem grow={false}>
                   <EuiTitle size="xs">
                     <h3>
-                      {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
                       <EuiLink href={workflowNav.href} onClick={handleWorkflowLinkClick}>
                         {`${stepExecution?.stepType}: ${childWorkflowExecution.workflowName}`}
                       </EuiLink>
@@ -239,7 +238,6 @@ export const WorkflowStepExecutionDetails = React.memo<WorkflowStepExecutionDeta
                 <EuiFlexItem grow={false}>
                   <EuiTitle size="xs">
                     <h3>
-                      {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
                       <EuiLink
                         href={parentWorkflowNav.href}
                         onClick={handleParentWorkflowLinkClick}

x-pack/platform/plugins/private/upgrade_assistant/public/application/components/es_deprecation_logs/fix_deprecation_logs/external_links.tsx

@@ -134,7 +134,6 @@ const DiscoverAppLink: FunctionComponent<Omit<Props, 'showInfoParagraph'>> = ({
       {content}
     </EuiButton>
   ) : (
-    // eslint-disable-next-line @elastic/eui/href-or-on-click
     <EuiLink href={discoveryUrl} onClick={handleClick} data-test-subj="viewDiscoverLogs">
       <EuiText> {content}</EuiText>
     </EuiLink>

x-pack/platform/plugins/shared/automatic_import/public/components/create_integration_card_button/create_integration_card_button.tsx

@@ -163,7 +163,6 @@ export const CreateIntegrationSideCardButton = React.memo(() => {
                   defaultMessage="Use AI to create a new one or {uploadLink}"
                   values={{
                     uploadLink: (
-                      // eslint-disable-next-line @elastic/eui/href-or-on-click
                       <EuiLink
                         href={uploadHref}
                         onClick={navigateToUpload}

x-pack/platform/plugins/shared/content_connectors/public/components/shared/header_actions/syncs_context_menu.test.tsx

@@ -4,7 +4,6 @@
  * 2.0; you may not use this file except in compliance with the Elastic License
  * 2.0.
  */
-import '../../../__mocks__/shallow_useeffect.mock';
 import { setMockActions, setMockValues } from '../../../__mocks__';
 import React from 'react';
 

x-pack/platform/plugins/shared/fleet/public/applications/fleet/components/fleet_server_instructions/steps/add_fleet_server_host.tsx

@@ -274,7 +274,6 @@ export const AddFleetServerHostStepContent = ({
               values={{
                 host: submittedFleetServerHost.host_urls[0],
                 fleetSettingsLink: (
-                  // eslint-disable-next-line @elastic/eui/href-or-on-click
                   <EuiLink href={getHref('settings')} onClick={onClose}>
                     <FormattedMessage
                       id="xpack.fleet.fleetServerSetup.fleetSettingsLink"

x-pack/platform/plugins/shared/fleet/public/applications/fleet/components/fleet_server_instructions/steps/get_started.tsx

@@ -78,7 +78,6 @@ const GettingStartedStepContent: React.FunctionComponent<QuickStartCreateForm> =
             values={{
               hostUrl: <EuiCode>{selectedFleetServerHost?.host_urls[0]}</EuiCode>,
               fleetSettingsLink: (
-                // eslint-disable-next-line @elastic/eui/href-or-on-click
                 <EuiLink href={getHref('settings')} onClick={onClose}>
                   <FormattedMessage
                     id="xpack.fleet.fleetServerSetup.fleetSettingsLink"

x-pack/platform/plugins/shared/osquery/public/agent_policies/agents_policy_link.tsx

@@ -51,7 +51,6 @@ const AgentsPolicyLinkComponent: React.FC<AgentsPolicyLinkProps> = ({ policyId }
   );
 
   return (
-    // eslint-disable-next-line @elastic/eui/href-or-on-click
     <EuiLink href={href} onClick={handleClick} css={euiLinkCss}>
       {data?.name ?? policyId}
     </EuiLink>

x-pack/platform/plugins/shared/saved_objects_tagging/public/management/components/table.tsx

@@ -127,7 +127,6 @@ export const TagTable: FC<TagTableProps> = ({
         );
 
         return capabilities.viewConnections ? (
-          // eslint-disable-next-line @elastic/eui/href-or-on-click
           <EuiLink
             data-test-subj="tagsTableRowConnectionsLink"
             href={getTagRelationUrl(tag)}

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/bedrock/dashboard_link.tsx

@@ -40,7 +40,6 @@ export const DashboardLink: React.FC<Props> = ({
   return dashboardUrl != null ? (
     // href gives us right click -> open in new tab
     // onclick prevents page reload
-    // eslint-disable-next-line @elastic/eui/href-or-on-click
     <EuiLink data-test-subj="link-gen-ai-token-dashboard" onClick={onClick} href={dashboardUrl}>
       {i18n.USAGE_DASHBOARD_LINK(selectedProvider, connectorName)}
     </EuiLink>

x-pack/platform/plugins/shared/stack_connectors/public/connector_types/gemini/dashboard_link.tsx

@@ -40,7 +40,6 @@ export const DashboardLink: React.FC<Props> = ({
   return dashboardUrl != null ? (
     // href gives us right click -> open in new tab
     // onclick prevents page reload
-    // eslint-disable-next-line @elastic/eui/href-or-on-click
     <EuiLink data-test-subj="link-gen-ai-token-dashboard" onClick={onClick} href={dashboardUrl}>
       {i18n.USAGE_DASHBOARD_LINK(selectedProvider, connectorName)}
     </EuiLink>

x-pack/solutions/observability/plugins/metrics_data_access/public/components/infrastructure_node_metrics_tables/shared/components/metrics_node_details_link.tsx

@@ -112,7 +112,6 @@ export const MetricsNodeDetailsLink = ({
   ]);
 
   return (
-    // eslint-disable-next-line @elastic/eui/href-or-on-click -- onClick for programmatic navigation; href for "Open in new tab" and fallback
     <EuiLink
       data-test-subj="infraMetricsNodeDetailsLinkLink"
       href={linkProps.href}

x-pack/solutions/observability/plugins/observability/public/pages/alert_details/components/related_dashboards/dashboard_tile.tsx

@@ -55,8 +55,6 @@ export function DashboardTile({
     <>
       <EuiFlexGroup gutterSize="xs" responsive={false} key={dashboard.id} alignItems="center">
         <EuiFlexGroup key={dashboard.id} gutterSize="s" direction="column">
-          {/* Allowing both href and onClick to allow telemetry to be reported */}
-          {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
           <EuiLink
             data-test-subj={`alertDetails_viewLinkedDashboard_${actionButtonProps?.ruleType}`}
             href={dashboardLocator?.getRedirectUrl({

x-pack/solutions/search/plugins/enterprise_search/public/applications/enterprise_search_content/components/shared/header_actions/syncs_context_menu.test.tsx

@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-import '../../../../__mocks__/shallow_useeffect.mock';
 import { setMockValues, setMockActions } from '../../../../__mocks__/kea_logic';
 
 import React from 'react';

x-pack/solutions/search/plugins/search_query_rules/public/components/query_ruleset_detail/query_rule_flyout/query_rule_flyout.tsx

@@ -179,7 +179,6 @@ export const QueryRuleFlyout: React.FC<QueryRuleFlyoutProps> = ({
                   id="xpack.search.queryRulesetDetail.queryRuleFlyout.findDocuments"
                   defaultMessage="Find your documents IDs into "
                 />
-                {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
                 <EuiLink
                   data-test-subj="searchQueryRulesQueryRuleFlyoutLink"
                   external

x-pack/solutions/security/plugins/security_solution/public/cases/attachments/endpoint/endpoint_event.tsx

@@ -50,7 +50,6 @@ const EndpointEventLink = ({ target, actionText, remainingTargets }: EndpointEve
   return (
     <>
       {actionText}
-      {/* eslint-disable-next-line @elastic/eui/href-or-on-click */}
       <EuiLink
         onClick={onLinkClick}
         href={linkHref}