[9.4] [Actions] Fix HTTP connector TLS options through proxies (#269898)#270104
Merged
Conversation
) ## Summary - For HTTPS requests through an HTTP proxy, forward target TLS options to the CONNECT-upgraded request created by `HttpsProxyAgent`. - Ensures connector `verificationMode: none` and per-request SSL overrides like `fetcher.skip_ssl_verification` are honored when the proxy performs TLS inspection. - Adds a regression test covering target SSL overrides through the proxy agent callback. ## Test plan - `node scripts/jest src/platform/packages/shared/kbn-actions-utils/utils/get_custom_agents.test.ts` - `node scripts/check_changes.ts` - Manually reproduced with local mitmproxy before the fix and verified `_execute` succeeds after the fix. ## References Closes elastic/security-team#17454 Closes elastic#196602 Made with [Cursor](https://cursor.com) Co-authored-by: Cursor <cursoragent@cursor.com> (cherry picked from commit 4783bfa)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @shahargl |
shahargl
added a commit
that referenced
this pull request
Jun 24, 2026
…) (#274812) # Backport This will backport the following commits from `main` to `9.3`: - [[Actions] Fix HTTP connector TLS options through proxies (#269898)](#269898) <!--- Backport version: 11.0.2 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Shahar Glazner","email":"shaharglazner@gmail.com"},"sourceCommit":{"committedDate":"2026-05-20T08:50:22Z","message":"[Actions] Fix HTTP connector TLS options through proxies (#269898)\n\n## Summary\n- For HTTPS requests through an HTTP proxy, forward target TLS options\nto the CONNECT-upgraded request created by `HttpsProxyAgent`.\n- Ensures connector `verificationMode: none` and per-request SSL\noverrides like `fetcher.skip_ssl_verification` are honored when the\nproxy performs TLS inspection.\n- Adds a regression test covering target SSL overrides through the proxy\nagent callback.\n\n## Test plan\n- `node scripts/jest\nsrc/platform/packages/shared/kbn-actions-utils/utils/get_custom_agents.test.ts`\n- `node scripts/check_changes.ts`\n- Manually reproduced with local mitmproxy before the fix and verified\n`_execute` succeeds after the fix.\n\n## References\nCloses elastic/security-team#17454\nCloses https://github.com/elastic/kibana/issues/196602\n\nMade with [Cursor](https://cursor.com)\n\nCo-authored-by: Cursor <cursoragent@cursor.com>","sha":"4783bfafd2d0e25d59d5f2a835ef5f84defd1333","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","backport:all-open","Team:One Workflow","v9.5.0","v9.4.2"],"title":"[Actions] Fix HTTP connector TLS options through proxies","number":269898,"url":"https://github.com/elastic/kibana/pull/269898","mergeCommit":{"message":"[Actions] Fix HTTP connector TLS options through proxies (#269898)\n\n## Summary\n- For HTTPS requests through an HTTP proxy, forward target TLS options\nto the CONNECT-upgraded request created by `HttpsProxyAgent`.\n- Ensures connector `verificationMode: none` and per-request SSL\noverrides like `fetcher.skip_ssl_verification` are honored when the\nproxy performs TLS inspection.\n- Adds a regression test covering target SSL overrides through the proxy\nagent callback.\n\n## Test plan\n- `node scripts/jest\nsrc/platform/packages/shared/kbn-actions-utils/utils/get_custom_agents.test.ts`\n- `node scripts/check_changes.ts`\n- Manually reproduced with local mitmproxy before the fix and verified\n`_execute` succeeds after the fix.\n\n## References\nCloses elastic/security-team#17454\nCloses https://github.com/elastic/kibana/issues/196602\n\nMade with [Cursor](https://cursor.com)\n\nCo-authored-by: Cursor <cursoragent@cursor.com>","sha":"4783bfafd2d0e25d59d5f2a835ef5f84defd1333"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/269898","number":269898,"mergeCommit":{"message":"[Actions] Fix HTTP connector TLS options through proxies (#269898)\n\n## Summary\n- For HTTPS requests through an HTTP proxy, forward target TLS options\nto the CONNECT-upgraded request created by `HttpsProxyAgent`.\n- Ensures connector `verificationMode: none` and per-request SSL\noverrides like `fetcher.skip_ssl_verification` are honored when the\nproxy performs TLS inspection.\n- Adds a regression test covering target SSL overrides through the proxy\nagent callback.\n\n## Test plan\n- `node scripts/jest\nsrc/platform/packages/shared/kbn-actions-utils/utils/get_custom_agents.test.ts`\n- `node scripts/check_changes.ts`\n- Manually reproduced with local mitmproxy before the fix and verified\n`_execute` succeeds after the fix.\n\n## References\nCloses elastic/security-team#17454\nCloses https://github.com/elastic/kibana/issues/196602\n\nMade with [Cursor](https://cursor.com)\n\nCo-authored-by: Cursor <cursoragent@cursor.com>","sha":"4783bfafd2d0e25d59d5f2a835ef5f84defd1333"}},{"branch":"9.4","label":"v9.4.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/270104","number":270104,"state":"MERGED","mergeCommit":{"sha":"a52796fd91238e42d13f5044f0fd8958aabe08ee","message":"[9.4] [Actions] Fix HTTP connector TLS options through proxies (#269898) (#270104)\n\n# Backport\n\nThis will backport the following commits from `main` to `9.4`:\n- [[Actions] Fix HTTP connector TLS options through proxies\n(#269898)](https://github.com/elastic/kibana/pull/269898)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by: Shahar Glazner <shaharglazner@gmail.com>\nCo-authored-by: Cursor <cursoragent@cursor.com>"}},{"url":"https://github.com/elastic/kibana/pull/272321","number":272321,"branch":"8.19","state":"OPEN"}]}] BACKPORT--> --- **Note:** This PR was created with conflicts auto-resolved in favor of the source commit (`--strategy-option=theirs`). Please review the changes carefully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation