Skip to content

Add aria-label to Custom Instructions textarea in edit details flyout#271073

Merged
bhavyarm merged 4 commits into
mainfrom
copilot/fix-custom-instructions-field-title
May 27, 2026
Merged

Add aria-label to Custom Instructions textarea in edit details flyout#271073
bhavyarm merged 4 commits into
mainfrom
copilot/fix-custom-instructions-field-title

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 25, 2026

The Custom Instructions EuiTextArea in the Agent Builder edit details flyout has no accessible name. Screen readers only announce placeholder text, not the field title — violating WCAG 4.1.2 (Name, Role, Value).

  • Added aria-label={flyoutLabels.instructionsTitle} to the EuiTextArea, reusing the existing i18n string already rendered as the visual heading

Copilot AI changed the title [WIP] Fix custom instructions field title announcement Add aria-label to Custom Instructions textarea in edit details flyout May 25, 2026
Copilot AI requested a review from bhavyarm May 25, 2026 13:16
@bhavyarm bhavyarm added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes a11y:agent-pr PR has been created by the agent backport:version Backport to applied version labels v9.5.0 v9.3.5 v9.4.2 labels May 25, 2026
@bhavyarm bhavyarm marked this pull request as ready for review May 25, 2026 19:51
@bhavyarm bhavyarm requested a review from a team as a code owner May 25, 2026 19:51
@infra-vault-gh-plugin-prod
Copy link
Copy Markdown

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 1.3MB 1.3MB +34.0B

History

cc @bhavyarm @Copilot

@bhavyarm bhavyarm merged commit 07487ae into main May 27, 2026
30 checks passed
@bhavyarm bhavyarm deleted the copilot/fix-custom-instructions-field-title branch May 27, 2026 13:13
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 9.3, 9.4

https://github.com/elastic/kibana/actions/runs/26513312603

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
9.3 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.3:
- Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)
- [Synthetics] Wait for active space before fetching cross-space monitor in flyout !! (#270936)
- [Scout] Sanitize Buildkite step keys for nested plugin names (#271412)
- [Fleet] Normalize endpoint package policy input ids (#271269)
9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 271073

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 29, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @bhavyarm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a11y:agent-pr PR has been created by the agent backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels 💝community Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.3.5 v9.4.2 v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Search:Overview] Custom instructions field missing title from announcement

4 participants