Skip to content

[One Workflow] Add managed workflow badge and read-only restrictions#271160

Merged
rosomri merged 7 commits into
elastic:mainfrom
rosomri:fix/managed-workflow-ui-readonly
May 31, 2026
Merged

[One Workflow] Add managed workflow badge and read-only restrictions#271160
rosomri merged 7 commits into
elastic:mainfrom
rosomri:fix/managed-workflow-ui-readonly

Conversation

@rosomri
Copy link
Copy Markdown
Contributor

@rosomri rosomri commented May 25, 2026

Summary

  • Adds a managed badge to workflow list and detail views for managed workflows.
  • Makes managed workflow YAML read-only while keeping the enable/disable toggle editable.
  • Prevents managed workflows from being deleted through row actions or bulk actions, and explains the disabled row delete action with managed-specific hover text.
  • Covers the new badge, read-only, listing, and delete behavior with focused workflows UI/server tests.
image image image image

Test plan

  • node scripts/jest src/platform/plugins/shared/workflows_management/public/widgets/workflow_yaml_editor/ui/workflow_yaml_editor.test.tsx src/platform/plugins/shared/workflows_management/public/pages/workflow_detail/ui/workflow_detail_header.test.tsx src/platform/plugins/shared/workflows_management/public/features/workflow_list/ui/workflow_list.test.tsx
  • node scripts/jest src/platform/plugins/shared/workflows_management/server/services/workflow_search_service.test.ts
  • node scripts/jest src/platform/plugins/shared/workflows_management/public/features/workflow_list/ui/workflow_list.authorization.test.tsx src/platform/plugins/shared/workflows_management/public/features/workflow_list/ui/use_workflow_bulk_actions.test.tsx
  • node scripts/check_changes.ts

References

Closes elastic/security-team#17549

@rosomri rosomri added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Team:One Workflow Team label for One Workflow (Workflow automation) v9.3.0 v9.4.0 backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels v9.3.0 v9.4.0 labels May 25, 2026
rosomri added 2 commits May 26, 2026 10:54
Prevent managed workflows from being deleted from row and bulk list actions.

Closes elastic/security-team#17549
@rosomri rosomri changed the title [One Workflow] Add managed workflow badge and read-only YAML [One Workflow] Add managed workflow badge and read-only restrictions May 26, 2026
@rosomri rosomri marked this pull request as ready for review May 26, 2026 11:17
@rosomri rosomri requested a review from a team as a code owner May 26, 2026 11:17
@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
workflowsManagement 1892 1893 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
workflowsManagement 2.5MB 2.5MB +1.5KB

History

cc @rosomri

Copy link
Copy Markdown
Contributor

@h88 h88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Summary mentions default-including managed workflows + workflow_search_service changes but the PR seems UI-only? getWorkflows still defaults to managedFilter ?? 'unmanaged', so list badge/delete UX won’t show on the main list. Please either add the server/list changes or trim the PR description...

@rosomri rosomri merged commit 3790a2e into elastic:main May 31, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:One Workflow Team label for One Workflow (Workflow automation) v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants