[ES|QL] Make autocomplete fully marker-free - follow up#271222
Draft
bartoval wants to merge 3 commits into
Draft
[ES|QL] Make autocomplete fully marker-free - follow up#271222bartoval wants to merge 3 commits into
bartoval wants to merge 3 commits into
Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
bartoval
changed the title
bartoval
force-pushed
the
esql/autocomplete-marker-free-ast
branch
from
26ed90d to
c64c8fc
Compare
bartoval
changed the title
bartoval
force-pushed
the
esql/autocomplete-marker-free-ast
branch
from
c64c8fc to
04385b0
Compare
bartoval
force-pushed
the
esql/autocomplete-marker-free-ast
branch
from
1607426 to
2e87a2b
Compare
bartoval
force-pushed
the
esql/autocomplete-marker-free-ast
branch
from
2e87a2b to
5a08fa0
Compare
bartoval
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In this PR #260618, I continued the existing marker cleanup work, following the current logic to avoid to break something. This clean well all cases that go through the cleanup functions, but there were still two or three cases that did not pass through them.
After reconsidering the problem, I decided to remove the marker immediately after parsing. This should cover all cases, including PROMQL.