Skip to content

[9.4] Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)#271442

Merged
kibanamachine merged 2 commits into
elastic:9.4from
kibanamachine:backport/9.4/pr-271377
May 27, 2026
Merged

[9.4] Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)#271442
kibanamachine merged 2 commits into
elastic:9.4from
kibanamachine:backport/9.4/pr-271377

Conversation

@kibanamachine
Copy link
Copy Markdown
Contributor

Backport

This will backport the following commits from main to 9.4:

Questions ?

Please refer to the Backport tool documentation

…anager UI (elastic#271377)

Two `EuiInMemoryTable` instances in the drilldown manager UI were
missing the required `tableCaption` prop, violating
`@elastic/eui/require-table-caption`.

### Changes

- **`drilldown_template_table`** — Added `tableCaption` with i18n
string: *"Drilldown templates"*
- **`drilldown_table`** — Added `tableCaption` with i18n string:
*"Drilldowns"*

```tsx
<EuiInMemoryTable
  tableCaption={txtTableCaption}
  items={drilldowns}
  // ...
/>
```

Captions describe the dataset per EUI accessibility guidelines and use
`i18n.translate` for localization.

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
(cherry picked from commit fa6e1f1)
@kibanamachine kibanamachine added the backport This PR is a backport of another PR label May 27, 2026
@botelastic botelastic Bot added Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame labels May 27, 2026
@kibanamachine kibanamachine enabled auto-merge (squash) May 27, 2026 12:33
@kibanamachine
Copy link
Copy Markdown
Contributor Author

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Scout Lane #8 - stateful-classic / default / local-stateful-classic - Observability Landing Page (discover.isEsqlDefault enabled) - redirects to onboarding when no logs data exists

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
embeddable 42.2KB 42.5KB +261.0B

History

cc @alexwizp

@kibanamachine kibanamachine merged commit 8fceb68 into elastic:9.4 May 27, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR Feature:Drilldowns Embeddable panel Drilldowns Feature:Embedding Embedding content via iFrame

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants