Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI#271377
Merged
alexwizp merged 5 commits intoMay 27, 2026
Merged
Conversation
5 tasks
Adds the required `tableCaption` prop to two `EuiInMemoryTable` instances in the drilldown manager UI to fix `@elastic/eui/require-table-caption` ESLint violations for the @elastic/kibana-presentation team.
Copilot
AI
changed the title
[WIP] Fix lint violations for @elastic/eui/require-table-caption
Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI
May 27, 2026
botelastic
Bot
added
Feature:Drilldowns
alexwizp
added
Project:Accessibility
release_note:skip
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
Contributor
|
/ci |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @alexwizp @Copilot |
botelastic
Bot
added
Feature:Drilldowns
alexwizp
deleted the
copilot/eslint-issue-reporterfix-require-table-caption-vio
branch
Contributor
|
Starting backport for target branches: 9.3, 9.4 |
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced May 27, 2026
kibanamachine
added a commit
that referenced
this pull request
May 27, 2026
…down manager UI (#271377) (#271442) # Backport This will backport the following commits from `main` to `9.4`: - [Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)](#271377) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-27T12:22:43Z","message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Project:Accessibility","release_note:skip","Feature:Drilldowns","💝community","backport:version","a11y:agent-pr","v9.5.0","v9.3.5","v9.4.2"],"title":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI","number":271377,"url":"https://github.com/elastic/kibana/pull/271377","mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/271377","number":271377,"mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
smith
pushed a commit
to smith/kibana
that referenced
this pull request
May 27, 2026
…anager UI (elastic#271377) Two `EuiInMemoryTable` instances in the drilldown manager UI were missing the required `tableCaption` prop, violating `@elastic/eui/require-table-caption`. ### Changes - **`drilldown_template_table`** — Added `tableCaption` with i18n string: *"Drilldown templates"* - **`drilldown_table`** — Added `tableCaption` with i18n string: *"Drilldowns"* ```tsx <EuiInMemoryTable tableCaption={txtTableCaption} items={drilldowns} // ... /> ``` Captions describe the dataset per EUI accessibility guidelines and use `i18n.translate` for localization. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
added
the
backport missing
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
May 29, 2026
…anager UI (elastic#271377) Two `EuiInMemoryTable` instances in the drilldown manager UI were missing the required `tableCaption` prop, violating `@elastic/eui/require-table-caption`. ### Changes - **`drilldown_template_table`** — Added `tableCaption` with i18n string: *"Drilldown templates"* - **`drilldown_table`** — Added `tableCaption` with i18n string: *"Drilldowns"* ```tsx <EuiInMemoryTable tableCaption={txtTableCaption} items={drilldowns} // ... /> ``` Captions describe the dataset per EUI accessibility guidelines and use `i18n.translate` for localization. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
May 29, 2026
…down manager UI (#271377) (#271440) # Backport This will backport the following commits from `main` to `9.3`: - [Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)](#271377) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Copilot","email":"198982749+Copilot@users.noreply.github.com"},"sourceCommit":{"committedDate":"2026-05-27T12:22:43Z","message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec","branchLabelMapping":{"^v9.5.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Embedding","Project:Accessibility","release_note:skip","Feature:Drilldowns","💝community","backport:version","a11y:agent-pr","v9.5.0","v9.3.5","v9.4.2"],"title":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI","number":271377,"url":"https://github.com/elastic/kibana/pull/271377","mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},"sourceBranch":"main","suggestedTargetBranches":["9.3","9.4"],"targetPullRequestStates":[{"branch":"main","label":"v9.5.0","branchLabelMappingKey":"^v9.5.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/271377","number":271377,"mergeCommit":{"message":"Fix @elastic/eui/require-table-caption lint violations in drilldown manager UI (#271377)\n\nTwo `EuiInMemoryTable` instances in the drilldown manager UI were\nmissing the required `tableCaption` prop, violating\n`@elastic/eui/require-table-caption`.\n\n### Changes\n\n- **`drilldown_template_table`** — Added `tableCaption` with i18n\nstring: *\"Drilldown templates\"*\n- **`drilldown_table`** — Added `tableCaption` with i18n string:\n*\"Drilldowns\"*\n\n```tsx\n<EuiInMemoryTable\n tableCaption={txtTableCaption}\n items={drilldowns}\n // ...\n/>\n```\n\nCaptions describe the dataset per EUI accessibility guidelines and use\n`i18n.translate` for localization.\n\n---------\n\nCo-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>\nCo-authored-by: Alexey Antonov <alexwizp@gmail.com>","sha":"fa6e1f14d584a5fc26a2e62c3a4bbad2cb1c68ec"}},{"branch":"9.3","label":"v9.3.5","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.4","label":"v9.4.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>
kibanamachine
removed
the
backport missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
EuiInMemoryTableinstances in the drilldown manager UI were missing the requiredtableCaptionprop, violating@elastic/eui/require-table-caption.Changes
drilldown_template_table— AddedtableCaptionwith i18n string: "Drilldown templates"drilldown_table— AddedtableCaptionwith i18n string: "Drilldowns"Captions describe the dataset per EUI accessibility guidelines and use
i18n.translatefor localization.