Skip to content

feat(kibana-cases): replace title props and wrap EuiButtonIcon with EuiToolTip #271478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weronikaolejniczak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(kibana-cases): replace title props and wrap EuiButtonIcon with EuiToolTip #271478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8e5f35
feat(kibana-cases): replace title props and wrap EuiButtonIcon with E…
weronikaolejniczak May 27, 2026
fef493a
fix(kibana-cases): query saved icon by data-test-subj
weronikaolejniczak May 28, 2026
a6bef5c
Merge branch 'main' into feat/replace-title-kibana-cases
alexwizp Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions x-pack/platform/plugins/shared/cases/public/components/all_cases/use_actions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type {
EuiContextMenuPanelItemDescriptor,
EuiTableComputedColumnType,
} from '@elastic/eui';
import { EuiButtonIcon, EuiContextMenu, EuiPopover } from '@elastic/eui';
import { EuiButtonIcon, EuiContextMenu, EuiPopover, EuiToolTip } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n-react';
import { CaseStatuses } from '@kbn/cases-components';
import type { CaseUI } from '../../containers/types';
Expand Down Expand Up @@ -225,16 +225,21 @@ const ActionColumnComponent: React.FC<{ theCase: CaseUI; disableActions: boolean
key={`case-action-popover-${theCase.id}`}
data-test-subj={`case-action-popover-${theCase.id}`}
button={
<EuiButtonIcon
onClick={togglePopover}
iconType="boxesVertical"
aria-label={i18n.ACTIONS_BUTTON_ARIA_LABEL(theCase.title)}
color="text"
key={`case-action-popover-button-${theCase.id}`}
data-test-subj={`case-action-popover-button-${theCase.id}`}
disabled={disableActions}
buttonRef={buttonRef}
/>
<EuiToolTip
content={i18n.ACTIONS_BUTTON_ARIA_LABEL(theCase.title)}
disableScreenReaderOutput
>
<EuiButtonIcon
onClick={togglePopover}
iconType="boxesVertical"
aria-label={i18n.ACTIONS_BUTTON_ARIA_LABEL(theCase.title)}
color="text"
key={`case-action-popover-button-${theCase.id}`}
data-test-subj={`case-action-popover-button-${theCase.id}`}
disabled={disableActions}
buttonRef={buttonRef}
/>
</EuiToolTip>
}
isOpen={isPopoverOpen}
closePopover={closePopover}
Expand Down
29 changes: 19 additions & 10 deletions ...m/plugins/shared/cases/public/components/attachments/file/file_actions_popover_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,14 @@ import type {
EuiContextMenuPanelDescriptor,
EuiContextMenuPanelItemDescriptor,
} from '@elastic/eui';
import { EuiButtonIcon, EuiPopover, EuiContextMenu, EuiIcon, EuiTextColor } from '@elastic/eui';
import {
EuiButtonIcon,
EuiContextMenu,
EuiIcon,
EuiPopover,
EuiTextColor,
EuiToolTip,
} from '@elastic/eui';
import type { FileJSON } from '@kbn/shared-ux-file-types';
import { useFilesContext } from '@kbn/shared-ux-file-context';
import type { Owner } from '../../../../common/constants/types';
Expand Down Expand Up @@ -156,15 +163,17 @@ export const FileActionsPopoverButton: React.FC<{ caseId: string; theFile: FileJ
key={`cases-files-popover-${theFile.id}`}
data-test-subj={`cases-files-popover-${theFile.id}`}
button={
<EuiButtonIcon
onClick={tooglePopover}
iconType="boxesVertical"
aria-label={i18n.ACTIONS}
color="text"
key={`cases-files-actions-popover-button-${theFile.id}`}
data-test-subj={`cases-files-actions-popover-button-${theFile.id}`}
buttonRef={buttonRef}
/>
<EuiToolTip content={i18n.ACTIONS} disableScreenReaderOutput>
<EuiButtonIcon
onClick={tooglePopover}
iconType="boxesVertical"
aria-label={i18n.ACTIONS}
color="text"
key={`cases-files-actions-popover-button-${theFile.id}`}
data-test-subj={`cases-files-actions-popover-button-${theFile.id}`}
buttonRef={buttonRef}
/>
</EuiToolTip>
}
isOpen={isPopoverOpen}
closePopover={closePopover}
Expand Down
25 changes: 14 additions & 11 deletions ...ck/platform/plugins/shared/cases/public/components/case_view/components/edit_category.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,16 @@

import React, { useEffect, useState } from 'react';
import {
EuiTitle,
EuiText,
EuiHorizontalRule,
EuiFlexGroup,
EuiFlexItem,
EuiButton,
EuiButtonEmpty,
EuiButtonIcon,
EuiFlexGroup,
EuiFlexItem,
EuiHorizontalRule,
EuiLoadingSpinner,
EuiText,
EuiTitle,
EuiToolTip,
} from '@elastic/eui';
import type { FormHook } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import { Form, useForm } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
Expand Down Expand Up @@ -122,12 +123,14 @@ export const EditCategory = React.memo(({ isLoading, onSubmit, category }: EditC
{isLoadingAll && <EuiLoadingSpinner data-test-subj="category-loading" />}
{!isLoadingAll && permissions.update && (
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj="category-edit-button"
aria-label={i18n.EDIT_CATEGORIES_ARIA}
iconType={'pencil'}
onClick={onEdit}
/>
<EuiToolTip content={i18n.EDIT_CATEGORIES_ARIA} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="category-edit-button"
aria-label={i18n.EDIT_CATEGORIES_ARIA}
iconType={'pencil'}
onClick={onEdit}
/>
</EuiToolTip>
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
23 changes: 13 additions & 10 deletions x-pack/platform/plugins/shared/cases/public/components/case_view/components/edit_tags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@

import React, { useCallback, useState } from 'react';
import {
EuiTitle,
EuiHorizontalRule,
EuiFlexGroup,
EuiFlexItem,
EuiButton,
EuiButtonEmpty,
EuiButtonIcon,
EuiFlexGroup,
EuiFlexItem,
EuiHorizontalRule,
EuiLoadingSpinner,
EuiTitle,
EuiToolTip,
useEuiTheme,
} from '@elastic/eui';
import { css } from '@emotion/react';
Expand Down Expand Up @@ -86,12 +87,14 @@ export const EditTags = React.memo(({ isLoading, onSubmit, tags }: EditTagsProps
{isLoading && <EuiLoadingSpinner data-test-subj="tag-list-loading" />}
{!isLoading && permissions.update && (
<EuiFlexItem data-test-subj="tag-list-edit" grow={false}>
<EuiButtonIcon
data-test-subj="tag-list-edit-button"
aria-label={i18n.EDIT_TAGS_ARIA}
iconType={'pencil'}
onClick={() => setIsEditTags(true)}
/>
<EuiToolTip content={i18n.EDIT_TAGS_ARIA} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="tag-list-edit-button"
aria-label={i18n.EDIT_TAGS_ARIA}
iconType={'pencil'}
onClick={() => setIsEditTags(true)}
/>
</EuiToolTip>
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
26 changes: 17 additions & 9 deletions x-pack/platform/plugins/shared/cases/public/components/case_view/components/user_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,12 @@ import { sortBy } from 'lodash';
import type { EuiThemeComputed } from '@elastic/eui';
import {
EuiButtonIcon,
EuiTitle,
EuiHorizontalRule,
EuiFlexGroup,
EuiFlexItem,
EuiHorizontalRule,
EuiLoadingSpinner,
EuiTitle,
EuiToolTip,
useEuiTheme,
} from '@elastic/eui';

Expand Down Expand Up @@ -58,15 +59,22 @@ const renderUsers = (
<HoverableUserWithAvatar userInfo={userInfo} />
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj="user-list-email-button"
onClick={handleSendEmail.bind(null, userInfo.user?.email)}
iconType="mail"
aria-label={i18n.SEND_EMAIL_ARIA(
<EuiToolTip
content={i18n.SEND_EMAIL_ARIA(
userInfo.user?.full_name ? userInfo.user?.full_name : userInfo.user?.username ?? ''
)}
isDisabled={isEmpty(userInfo.user?.email)}
/>
disableScreenReaderOutput
>
<EuiButtonIcon
data-test-subj="user-list-email-button"
onClick={handleSendEmail.bind(null, userInfo.user?.email)}
iconType="mail"
aria-label={i18n.SEND_EMAIL_ARIA(
userInfo.user?.full_name ? userInfo.user?.full_name : userInfo.user?.username ?? ''
)}
isDisabled={isEmpty(userInfo.user?.email)}
/>
</EuiToolTip>
</EuiFlexItem>
</EuiFlexGroup>
));
Expand Down
45 changes: 28 additions & 17 deletions ...latform/plugins/shared/cases/public/components/custom_fields/custom_fields_list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,15 @@

import React, { useCallback, useState } from 'react';
import {
EuiPanel,
EuiBadge,
EuiButtonIcon,
EuiFlexGroup,
EuiFlexItem,
EuiPanel,
EuiSpacer,
EuiText,
EuiButtonIcon,
EuiToolTip,
useEuiTheme,
EuiBadge,
} from '@elastic/eui';
import * as i18n from '../translations';

Expand Down Expand Up @@ -84,22 +85,32 @@ const CustomFieldsListComponent: React.FC<Props> = (props) => {
<EuiFlexItem grow={false}>
<EuiFlexGroup alignItems="flexEnd" gutterSize="s">
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj={`${customField.key}-custom-field-edit`}
aria-label={`${customField.key}-custom-field-edit`}
iconType="pencil"
color="primary"
onClick={() => onEditCustomField(customField.key)}
/>
<EuiToolTip
content={`${customField.key}-custom-field-edit`}
disableScreenReaderOutput
>
<EuiButtonIcon
data-test-subj={`${customField.key}-custom-field-edit`}
aria-label={`${customField.key}-custom-field-edit`}
iconType="pencil"
color="primary"
onClick={() => onEditCustomField(customField.key)}
/>
</EuiToolTip>
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj={`${customField.key}-custom-field-delete`}
aria-label={`${customField.key}-custom-field-delete`}
iconType="minusCircle"
color="danger"
onClick={() => setSelectedItem(customField)}
/>
<EuiToolTip
content={`${customField.key}-custom-field-delete`}
disableScreenReaderOutput
>
<EuiButtonIcon
data-test-subj={`${customField.key}-custom-field-delete`}
aria-label={`${customField.key}-custom-field-delete`}
iconType="minusCircle"
color="danger"
onClick={() => setSelectedItem(customField)}
/>
</EuiToolTip>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexItem>
Expand Down
15 changes: 9 additions & 6 deletions x-pack/platform/plugins/shared/cases/public/components/custom_fields/number/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {
EuiHorizontalRule,
EuiLoadingSpinner,
EuiText,
EuiToolTip,
} from '@elastic/eui';
import type { FormHook } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import {
Expand Down Expand Up @@ -174,12 +175,14 @@ const EditComponent: CustomFieldType<CaseCustomFieldNumber>['Edit'] = ({
)}
{!isLoading && canUpdate && (
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj={`case-number-custom-field-edit-button-${customFieldConfiguration.key}`}
aria-label={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)}
iconType={'pencil'}
onClick={onEdit}
/>
<EuiToolTip content={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj={`case-number-custom-field-edit-button-${customFieldConfiguration.key}`}
aria-label={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)}
iconType={'pencil'}
onClick={onEdit}
/>
</EuiToolTip>
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
15 changes: 9 additions & 6 deletions x-pack/platform/plugins/shared/cases/public/components/custom_fields/text/edit.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import {
EuiHorizontalRule,
EuiLoadingSpinner,
EuiText,
EuiToolTip,
} from '@elastic/eui';
import type { FormHook } from '@kbn/es-ui-shared-plugin/static/forms/hook_form_lib';
import {
Expand Down Expand Up @@ -171,12 +172,14 @@ const EditComponent: CustomFieldType<CaseCustomFieldText>['Edit'] = ({
)}
{!isLoading && canUpdate && (
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj={`case-text-custom-field-edit-button-${customFieldConfiguration.key}`}
aria-label={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)}
iconType={'pencil'}
onClick={onEdit}
/>
<EuiToolTip content={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj={`case-text-custom-field-edit-button-${customFieldConfiguration.key}`}
aria-label={EDIT_CUSTOM_FIELDS_ARIA_LABEL(title)}
iconType={'pencil'}
onClick={onEdit}
/>
</EuiToolTip>
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
34 changes: 21 additions & 13 deletions x-pack/platform/plugins/shared/cases/public/components/description/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ import { css } from '@emotion/react';
import type { EuiThemeComputed } from '@elastic/eui';
import {
EuiButtonIcon,
EuiPanel,
EuiFlexGroup,
EuiFlexItem,
EuiPanel,
EuiText,
EuiToolTip,
useEuiTheme,
} from '@elastic/eui';

Expand Down Expand Up @@ -181,21 +182,28 @@ export const Description = ({
<EuiFlexGroup justifyContent="flexEnd" gutterSize="s">
<EuiFlexItem grow={false}>
{permissions.update ? (
<EuiButtonIcon
aria-label={i18n.EDIT_DESCRIPTION}
iconType="pencil"
onClick={() => setIsEditable(true)}
data-test-subj="description-edit-icon"
/>
<EuiToolTip content={i18n.EDIT_DESCRIPTION} disableScreenReaderOutput>
<EuiButtonIcon
aria-label={i18n.EDIT_DESCRIPTION}
iconType="pencil"
onClick={() => setIsEditable(true)}
data-test-subj="description-edit-icon"
/>
</EuiToolTip>
) : null}
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiButtonIcon
aria-label={isCollapsed ? i18n.EXPAND_DESCRIPTION : i18n.COLLAPSE_DESCRIPTION}
iconType={isCollapsed ? 'unfold' : 'fold'}
onClick={toggleCollapse}
data-test-subj="description-collapse-icon"
/>
<EuiToolTip
content={isCollapsed ? i18n.EXPAND_DESCRIPTION : i18n.COLLAPSE_DESCRIPTION}
disableScreenReaderOutput
>
<EuiButtonIcon
aria-label={isCollapsed ? i18n.EXPAND_DESCRIPTION : i18n.COLLAPSE_DESCRIPTION}
iconType={isCollapsed ? 'unfold' : 'fold'}
onClick={toggleCollapse}
data-test-subj="description-collapse-icon"
/>
</EuiToolTip>
</EuiFlexItem>
</EuiFlexGroup>
</EuiFlexGroup>
Expand Down
Loading
Loading