feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip by weronikaolejniczak · Pull Request #271481 · elastic/kibana

weronikaolejniczak · 2026-05-27T14:13:51Z

Important

These changes should be carefully tested visually by each code owner. Wrapping with EuiToolTip instead of passing title leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression.

This PR:

wraps ALL EuiButtonIcon with EuiToolTip, the content is the same as aria-label, any title passed to EuiButtonIcon is removed,
changes several title cases (not truncation related) to use EuiToolTip instead (if applicable).

…on with EuiToolTip

weronikaolejniczak · 2026-05-27T15:28:45Z

buildkite test this

weronikaolejniczak · 2026-05-28T13:42:49Z

buildkite test this

weronikaolejniczak · 2026-05-28T14:03:42Z

buildkite test this

infra-vault-gh-plugin-prod · 2026-05-28T15:08:29Z

Pinging @elastic/eui-team (EUI)

markov00

Only a test change on our code owned related to the changes to the unifiedTabs.

akowalska622

LGTM, leaving one nit and a question

akowalska622 · 2026-05-29T08:20:06Z

Code changes LGTM for this file, but a side question to @AlexGPlay - do we still need this file? It seems like we migrated fully to EUI split button and looks like a dead code.

It's only imported by the deprecated TopNavMenuItem, but no caller uses it, maybe worth adding some cleanup issue to the backlog

I guess first the TopNavMenuItem needs to be cleaned up and after that we can remove the @kbn/split-button package 😄

I agree it's dependent, but what I meant is to track it now (if it's good to go soon), otherwise we forget 😁

ah, yes! that definitely sounds like a good idea 😁

akowalska622 · 2026-05-29T08:24:13Z

All good ✅

akowalska622 · 2026-05-29T08:25:10Z

All good ✅

akowalska622 · 2026-05-29T08:26:23Z

All good ✅

akowalska622 · 2026-05-29T08:28:20Z

All good ✅

akowalska622 · 2026-05-29T08:34:01Z

-      await retry.try(async () => {
-        // click on the tab navigation left button 10 times to make the first tab visible
-        for (let i = 0; i < 10; i++) {
-          await testSubjects.click('unifiedTabs_tabsBar_scrollLeftBtn');


Is this deletion intentional?

@alexwizp?

Apparently, this was causing the FTRs to fail.

akowalska622 · 2026-05-29T08:42:15Z

All good ✅

akowalska622 · 2026-05-29T08:43:32Z

All good ✅

akowalska622 · 2026-05-29T08:49:42Z

A tooltip obscures the cell menu, I've added a change suggestion below

…ts/doc_viewer_table/table_cell_value.tsx Co-authored-by: Ania Kowalska <63072419+akowalska622@users.noreply.github.com>

kibanamachine · 2026-05-29T10:12:44Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: c3557aa
Build duration: 71 mins

Failed CI Steps

Test Failures

[job] [logs] Scout Lane #9 - stateful-classic / default / local-stateful-classic - Saved query menu — CRUD (Discover) - save, load, update, save-as-new, delete via the popover

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alertingVTwo`	879.0KB	879.3KB	+298.0B
`cloudSecurityPosture`	616.0KB	616.3KB	+298.0B
`dataViewFieldEditor`	100.3KB	100.8KB	+535.0B
`dataViewManagement`	145.6KB	146.0KB	+437.0B
`discover`	1.9MB	1.9MB	+575.0B
`esql`	921.6KB	921.9KB	+298.0B
`esqlDataGrid`	156.0KB	156.3KB	+298.0B
`lens`	2.1MB	2.1MB	+114.0B
`osquery`	1.3MB	1.3MB	+298.0B
`securitySolution`	12.1MB	12.1MB	+298.0B
`slo`	1.2MB	1.2MB	+298.0B
`unifiedDocViewer`	685.8KB	685.9KB	+73.0B
`workflowsManagement`	2.5MB	2.5MB	+298.0B
total			+4.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`navigation`	10.7KB	10.8KB	+57.0B

History

💚 Build #449680 succeeded 172323e
💔 Build #449655 failed b399d7e
💔 Build #449042 failed 27ea910
💔 Build #448945 failed ccd4bc6

kibanamachine · 2026-05-29T10:14:43Z

Starting backport for target branches: 9.4

https://github.com/elastic/kibana/actions/runs/26631540508

kibanamachine · 2026-05-29T10:24:05Z

💔 All backports failed

Status	Branch	Result
❌	9.4	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 271481

Questions ?

Please refer to the Backport tool documentation

miguel-sanchez-elastic · 2026-05-29T10:39:39Z

Hi @weronikaolejniczak , I have seen that #270161 was closed but I tested main and I see the browser tooltips and not the new ones.

Maybe we were doing something custom in our end and it wasn't covered.

Do you suggest that you have another look or I can get someone from my team to have a look into it, it is fine either way.

For reference, our experience is in Discover, when running TS metrics-*

akowalska622 · 2026-05-29T11:20:36Z

The icons from the screenshot are specific for the metrics profile, they weren't covered in this PR I believe

weronikaolejniczak · 2026-05-29T11:21:28Z

@miguel-sanchez-elastic hey, Miguel 👋🏻 sorry, I think while breaking down the large PR I mistakenly added the "Closes" keyword to this one. The change needed lives in @kbn/shared-ux-button-toolbar so it's separate to this PR. I re-opened the task. Thank you for the vigilance 🙏🏻

alexwizp · 2026-05-29T11:35:14Z

💚 All backports created successfully

Status	Branch	Result
✅	9.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

miguel-sanchez-elastic · 2026-05-29T12:46:28Z

No problem @weronikaolejniczak !

Also I noticed the following in Discover FROM logs-:

…on with EuiToolTip (elastic#271481) Closes elastic#270161 Relates to elastic/eui#9566 > [!IMPORTANT] > These changes **should be carefully tested visually by each code owner.** Wrapping with `EuiToolTip` instead of passing `title` leads to another DOM node and can potentially break the layout. In such cases, I would appreciate committing appropriate fixes to this PR directly, I cannot possibly setup and run all Kibana functionalities to fix every regression. This PR: - wraps ALL `EuiButtonIcon` with `EuiToolTip`, the content is the same as `aria-label`, any `title` passed to `EuiButtonIcon` is removed, - changes several `title` cases (not truncation related) to use `EuiToolTip` instead (if applicable). --------- Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Ania Kowalska <63072419+akowalska622@users.noreply.github.com>

feat(kibana-data-discovery): replace title props and wrap EuiButtonIc…

ccd4bc6

…on with EuiToolTip

weronikaolejniczak mentioned this pull request May 27, 2026

[EuiToolTip] Replace all title attributes with EuiToolTip #268225

Closed

8 tasks

weronikaolejniczak added backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes labels May 27, 2026

chore(kibana-data-discovery): update snapshots

27ea910

alexwizp added backport:version Backport to applied version labels v9.5.0 v9.4.2 and removed backport:skip This PR does not require backporting labels May 28, 2026

try to fix FTR

b399d7e

Merge branch 'main' into feat/replace-title-kibana-data-discovery

172323e

weronikaolejniczak marked this pull request as ready for review May 28, 2026 15:08

weronikaolejniczak requested review from a team as code owners May 28, 2026 15:08

akowalska622 self-requested a review May 28, 2026 15:40

markov00 approved these changes May 29, 2026

View reviewed changes

akowalska622 approved these changes May 29, 2026

View reviewed changes

Update src/platform/plugins/shared/unified_doc_viewer/public/componen…

c3557aa

…ts/doc_viewer_table/table_cell_value.tsx Co-authored-by: Ania Kowalska <63072419+akowalska622@users.noreply.github.com>

weronikaolejniczak merged commit 5993118 into elastic:main May 29, 2026
33 checks passed

weronikaolejniczak mentioned this pull request May 29, 2026

feat(appex-sharedux): suppress IconButtonGroup native title when toolTipContent is provided #271888

Draft

alexwizp mentioned this pull request May 29, 2026

[9.4] feat(kibana-data-discovery): replace title props and wrap EuiButtonIcon with EuiToolTip (#271481) #271895

Open

Conversation

weronikaolejniczak commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weronikaolejniczak commented May 27, 2026

Uh oh!

weronikaolejniczak commented May 28, 2026

Uh oh!

weronikaolejniczak commented May 28, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented May 28, 2026

Uh oh!

markov00 left a comment

Choose a reason for hiding this comment

Uh oh!

akowalska622 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kibanamachine commented May 29, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Uh oh!

kibanamachine commented May 29, 2026

Uh oh!

kibanamachine commented May 29, 2026

💔 All backports failed

Manual backport

Questions ?

Uh oh!

miguel-sanchez-elastic commented May 29, 2026

Uh oh!

akowalska622 commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weronikaolejniczak commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexwizp commented May 29, 2026

💚 All backports created successfully

Questions ?

Uh oh!

miguel-sanchez-elastic commented May 29, 2026

Uh oh!

Reviewers

Assignees

Labels

weronikaolejniczak commented May 27, 2026 •

edited

Loading

akowalska622 left a comment •

edited

Loading

akowalska622 commented May 29, 2026 •

edited

Loading

weronikaolejniczak commented May 29, 2026 •

edited

Loading