Skip to content

feat(obs-exploration-team): replace title props and wrap EuiButtonIcon with EuiToolTip #271494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
weronikaolejniczak wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(obs-exploration-team): replace title props and wrap EuiButtonIcon with EuiToolTip #271494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1483b03
feat(obs-exploration-team): replace title props and wrap EuiButtonIco…
weronikaolejniczak May 27, 2026
0b9ab02
Merge branch 'main' into feat/replace-title-obs-exploration-team
alexwizp May 29, 2026
d4d79e9
Merge branch 'main' into feat/replace-title-obs-exploration-team
alexwizp Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions ...-unified-chart-section-viewer/src/components/toolbar/right_side_actions/search_button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
EuiFlexGroup,
EuiFlexItem,
EuiButtonIcon,
EuiToolTip,
useEuiTheme,
keys,
} from '@elastic/eui';
Expand Down Expand Up @@ -123,25 +124,26 @@ export const SearchButton = ({
</EuiFlexItem>
) : (
<EuiFlexItem grow={false}>
<EuiButtonIcon
iconType="magnify"
aria-label={searchButtonLabel}
title={searchButtonLabel}
onClick={onShowSearch}
data-test-subj="metricsExperienceToolbarSearch"
size="s"
css={css`
border: ${euiTheme.border.thin};
border-top-right-radius: 0;
border-bottom-right-radius: 0;

&:focus {
outline: ${euiTheme.focus.width} solid ${euiTheme.focus.color};
outline-offset: -${euiTheme.focus.width};
}
`}
color="text"
/>
<EuiToolTip content={searchButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
iconType="magnify"
aria-label={searchButtonLabel}
onClick={onShowSearch}
data-test-subj="metricsExperienceToolbarSearch"
size="s"
css={css`
border: ${euiTheme.border.thin};
border-top-right-radius: 0;
border-bottom-right-radius: 0;

&:focus {
outline: ${euiTheme.focus.width} solid ${euiTheme.focus.color};
outline-offset: -${euiTheme.focus.width};
}
`}
color="text"
/>
</EuiToolTip>
</EuiFlexItem>
)}
</EuiFlexGroup>
Expand Down
19 changes: 10 additions & 9 deletions x-pack/platform/plugins/shared/logs_shared/public/components/data_search_progress.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* 2.0.
*/

import { EuiButtonIcon, EuiFlexGroup, EuiFlexItem, EuiProgress } from '@elastic/eui';
import { EuiButtonIcon, EuiFlexGroup, EuiFlexItem, EuiProgress, EuiToolTip } from '@elastic/eui';
import { i18n } from '@kbn/i18n';
import React, { useMemo } from 'react';

Expand All @@ -28,14 +28,15 @@ export const DataSearchProgress: React.FC<{
</EuiFlexItem>
{onCancel ? (
<EuiFlexItem grow={false}>
<EuiButtonIcon
data-test-subj="logsSharedDataSearchProgressButton"
color="danger"
iconType="cross"
onClick={onCancel}
title={cancelButtonLabel}
aria-label={cancelButtonLabel}
/>
<EuiToolTip content={cancelButtonLabel} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="logsSharedDataSearchProgressButton"
color="danger"
iconType="cross"
onClick={onCancel}
aria-label={cancelButtonLabel}
/>
</EuiToolTip>
</EuiFlexItem>
) : null}
</EuiFlexGroup>
Expand Down
25 changes: 14 additions & 11 deletions ...blic/pages/logs/log_entry_categories/sections/top_categories/category_example_message.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,15 @@ import { encode } from '@kbn/rison';
import moment from 'moment';
import React, { useCallback, useState } from 'react';
import {
EuiButtonIcon,
EuiContextMenuItem,
EuiContextMenuPanel,
EuiPopover,
EuiTable,
EuiTableBody,
EuiTableRow,
EuiTableRowCell,
EuiPopover,
EuiContextMenuPanel,
EuiContextMenuItem,
EuiButtonIcon,
EuiToolTip,
useEuiTheme,
} from '@elastic/eui';
import {
Expand Down Expand Up @@ -123,13 +124,15 @@ const CategoryExampleMessageRow: React.FC<CategoryExampleMessageRowProps> = ({
<EuiTableRowCell width="32px">
<EuiPopover
button={
<EuiButtonIcon
data-test-subj="infraCategoryExampleMessageRowButton"
aria-label={MENU_LABEL}
iconType="boxesVertical"
size="s"
onClick={toggleMenu}
/>
<EuiToolTip content={MENU_LABEL} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="infraCategoryExampleMessageRowButton"
aria-label={MENU_LABEL}
iconType="boxesVertical"
size="s"
onClick={toggleMenu}
/>
</EuiToolTip>
}
isOpen={isMenuOpen}
closePopover={closeMenu}
Expand Down
29 changes: 16 additions & 13 deletions ...y/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/log_entry_example.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,17 +13,18 @@ import { useMlHref, ML_PAGES } from '@kbn/ml-plugin/public';
import { useLinkProps, shouldHandleLinkEvent } from '@kbn/observability-shared-plugin/public';
import type { EuiThemeComputed } from '@elastic/eui';
import {
EuiButtonIcon,
EuiContextMenuItem,
EuiContextMenuPanel,
EuiPopover,
EuiScreenReaderOnly,
EuiTable,
EuiTableBody,
EuiTableHeader,
EuiTableHeaderCell,
EuiTableBody,
EuiTableRow,
EuiTableRowCell,
EuiPopover,
EuiContextMenuPanel,
EuiContextMenuItem,
EuiButtonIcon,
EuiScreenReaderOnly,
EuiToolTip,
useEuiTheme,
} from '@elastic/eui';
import { useKibanaContextForPlugin } from '../../../../../hooks/use_kibana';
Expand Down Expand Up @@ -175,13 +176,15 @@ export const LogEntryExampleMessageRow: React.FC<Props> = ({
<EuiTableRowCell width="48px">
<EuiPopover
button={
<EuiButtonIcon
data-test-subj="infraLogEntryExampleMessageRowButton"
aria-label={MENU_LABEL}
iconType="boxesVertical"
size="s"
onClick={toggleMenu}
/>
<EuiToolTip content={MENU_LABEL} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="infraLogEntryExampleMessageRowButton"
aria-label={MENU_LABEL}
iconType="boxesVertical"
size="s"
onClick={toggleMenu}
/>
</EuiToolTip>
}
isOpen={isMenuOpen}
closePopover={closeMenu}
Expand Down
33 changes: 19 additions & 14 deletions ...observability/plugins/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import {
EuiFlexItem,
EuiIcon,
EuiSpacer,
EuiToolTip,
RIGHT_ALIGNMENT,
} from '@elastic/eui';
import { i18n } from '@kbn/i18n';
Expand Down Expand Up @@ -302,23 +303,27 @@ const PaginationControls = ({
<EuiFlexGroup justifyContent="center">
<EuiFlexItem grow={false}>
<EuiFlexGroup>
<EuiButtonIcon
data-test-subj="infraPaginationControlsButton"
iconType="chevronSingleLeft"
isDisabled={!fetchPreviousPage || isLoading}
onClick={fetchPreviousPage}
aria-label={previousPageLabel}
/>
<EuiToolTip content={previousPageLabel} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="infraPaginationControlsButton"
iconType="chevronSingleLeft"
isDisabled={!fetchPreviousPage || isLoading}
onClick={fetchPreviousPage}
aria-label={previousPageLabel}
/>
</EuiToolTip>
<span>
<strong>{page}</strong>
</span>
<EuiButtonIcon
data-test-subj="infraPaginationControlsButton"
iconType="chevronSingleRight"
isDisabled={!fetchNextPage || isLoading}
onClick={fetchNextPage}
aria-label={nextPageLabel}
/>
<EuiToolTip content={nextPageLabel} disableScreenReaderOutput>
<EuiButtonIcon
data-test-subj="infraPaginationControlsButton"
iconType="chevronSingleRight"
isDisabled={!fetchNextPage || isLoading}
onClick={fetchNextPage}
aria-label={nextPageLabel}
/>
</EuiToolTip>
</EuiFlexGroup>
</EuiFlexItem>
</EuiFlexGroup>
Expand Down
Loading