feat(ci): per-config failing-test names in FTR job annotation#271518
Draft
TamerlanG wants to merge 1 commit into
Draft
feat(ci): per-config failing-test names in FTR job annotation#271518TamerlanG wants to merge 1 commit into
TamerlanG wants to merge 1 commit into
Conversation
Adds a `node scripts/ftr_annotation_helper snapshot / list-new-failures` CLI (backed by `ftr_annotation_helper.ts`) that diffs JUnit XML files written during each config run, so the job annotation can show exactly which tests failed per config without any shell temp-file plumbing. - `snapshotJunitDir`: records current *.xml paths to `.ftr_annotation_snapshot` - `collectNewFailedTestNames`: diffs snapshot vs current files, parses failures from new XMLs only, then deletes the snapshot file - `ftr_configs.sh` calls `snapshot` before each FTR run and `list-new-failures` in the failure branch; builds per-config annotation rows (passed / recovered / failed / still-failing / new-failure) and emits a `write_job_annotation` summary at the end
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds structured per-config test-failure details to the Buildkite FTR job annotation, without any shell temp-file plumbing.
How it works:
ftr_annotation_helper.tsexports two functions:snapshotJunitDir(dir)— records current*.xmlpaths to<dir>/.ftr_annotation_snapshotcollectNewFailedTestNames(dir)— diffs snapshot vs current XMLs, parses failures from new files only, deletes snapshotscripts/ftr_annotation_helper.jswires upsnapshot <dir>andlist-new-failures <dir>CLI subcommandsftr_configs.shcallssnapshotbefore each config run andlist-new-failuresin the failure branch to get per-config failing test namesftr_job_annotation.shcontainswrite_job_annotation()which emits a Buildkite annotation with:Annotation example:
Test plan
node scripts/jest packages/kbn-failed-test-reporter-cli/failed_tests_reporter/ftr_annotation_helper.test.ts(5 tests, all green)Related
Companion to #269605 (smart retry). This PR adds the annotation layer on top of
mainindependently, so it can land separately.