Extract Chrome app header infra fixes#271670
Merged
Dosant merged 4 commits intoMay 28, 2026
Merged
Conversation
Port small Chrome infrastructure fixes from the Chrome Next integration branch so main has the shared app menu visibility, Chrome Next helper, legacy action menu, and layout plumbing needed by app header consumers.
Document the badge rendering cases from the Chrome Next integration branch so the app header package has Storybook coverage for simple, clickable, overflow, and menu-backed badges.
Dosant
added
release_note:skip
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
angeles-mb
reviewed
May 28, 2026
angeles-mb
reviewed
May 28, 2026
| args: { | ||
| title: '[Logs] Web Traffic', | ||
| badges: [ | ||
| { label: 'Beta' }, |
Contributor
There was a problem hiding this comment.
Beta and New badges are clickable even if they don't have an onClick
Contributor
|
While checking stories, are these the final looks or do we still need to polish? Overflow badges positioning: Overlapping popovers: |
Keep useIsNextChrome in the browser hooks package only and remove duplicate browser-components feature flag plumbing.
angeles-mb
approved these changes
May 28, 2026
Contributor
angeles-mb
left a comment
angeles-mb
left a comment
There was a problem hiding this comment.
Approving to unblock the rest of the changes but we should take another look at the AppBadge later on.
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
|
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
May 29, 2026
Related: elastic#259318 ## Summary Ports a small set of Chrome infrastructure fixes from the Chrome Next integration branch to main, covering app menu static item visibility, Chrome Next helper plumbing, inline legacy action menu handling, header extension layout behavior, sidebar spacing, and the AppHeader badge Storybook story.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #259318
Summary
Ports a small set of Chrome infrastructure fixes from the Chrome Next integration branch to main, covering app menu static item visibility, Chrome Next helper plumbing, inline legacy action menu handling, header extension layout behavior, sidebar spacing, and the AppHeader badge Storybook story.