Skip to content

[Sig Events] Add Discovery navigation to global search#271690

Merged
mykolaharmash merged 3 commits into
elastic:mainfrom
mykolaharmash:sig-events-kibana-search
May 29, 2026
Merged

[Sig Events] Add Discovery navigation to global search#271690
mykolaharmash merged 3 commits into
elastic:mainfrom
mykolaharmash:sig-events-kibana-search

Conversation

@mykolaharmash
Copy link
Copy Markdown
Contributor

Adds core nav items of Sig Events Discovery (root, KIs, Rules and Events) to the Kibana's global search gated behind the observability:streamsEnableSignificantEventsDiscovery flag.

@mykolaharmash mykolaharmash requested review from a team as code owners May 28, 2026 12:05
@mykolaharmash mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) labels May 28, 2026
Comment on lines +42 to +47
const significantEventsDeepLinkIds = [
'significantEventsDiscovery',
'significantEventsKnowledgeIndicators',
'significantEventsEvents',
'significantEventsRules',
] as const;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the deep-links general package where we host all of these values?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, moved them in a82b48b

@mykolaharmash mykolaharmash requested a review from a team as a code owner May 28, 2026 14:13
@mykolaharmash mykolaharmash requested a review from tonyghiani May 28, 2026 14:15
@github-actions
Copy link
Copy Markdown
Contributor

@mykolaharmash, this PR increases one or more page-load bundle sizes by 15% or more:

Plugin Before (bytes) After (bytes) Change
streamsApp 25,375 29,825 +17.5%

Large bundle size increases can affect page load performance. Consider whether dependencies can be lazy-loaded or code split to reduce the bundle.

See the bundle optimization guide for tips.

@kibanamachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 2256 2257 +1
dataQuality 70 71 +1
datasetQuality 1121 1122 +1
dataUsage 56 57 +1
discover 2107 2108 +1
indexManagement 783 784 +1
infra 1913 1914 +1
ingestHub 43 44 +1
logsShared 485 486 +1
observability 1818 1819 +1
observabilityAIAssistantApp 853 854 +1
observabilityLogsExplorer 306 307 +1
observabilityOnboarding 147 148 +1
observabilityShared 247 248 +1
profiling 280 281 +1
slo 1387 1388 +1
streamsApp 1955 1956 +1
triggersActionsUi 1863 1864 +1
unifiedDocViewer 982 983 +1
uptime 760 761 +1
ux 164 165 +1
total +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
streamsApp 2.1MB 2.1MB -758.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
streamsApp 24.2KB 26.5KB +2.3KB

History

@mykolaharmash mykolaharmash merged commit cf48425 into elastic:main May 29, 2026
32 checks passed
dej611 pushed a commit to dej611/kibana that referenced this pull request May 29, 2026
Adds core nav items of Sig Events Discovery (root, KIs, Rules and
Events) to the Kibana's global search gated behind the
`observability:streamsEnableSignificantEventsDiscovery` flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting Feature:SigEvents Significant events feature, related to streams and rules/alerts (RnA) release_note:skip Skip the PR/issue when compiling release notes v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants