[Scout] Move Home / Sample Data API from FTR to Scout#271695
Draft
paulinashakirova wants to merge 8 commits into
Draft
[Scout] Move Home / Sample Data API from FTR to Scout#271695paulinashakirova wants to merge 8 commits into
paulinashakirova wants to merge 8 commits into
Conversation
- Introduced a new Playwright configuration file to set up testing environment. - Created constants for the flights dataset, including IDs and headers. - Implemented sample data API tests to validate installation and uninstallation of the flights dataset, ensuring proper handling of timestamps and API responses. - Removed outdated sample data tests from the home API integration suite. This update enhances the testing framework for the flights dataset, ensuring robust coverage and validation of sample data APIs.
paulinashakirova
added
release_note:skip
Contributor
Author
|
/flaky scoutConfig:src/platform/plugins/shared/home/test/scout/api/playwright.config.ts:30 |
Contributor
Author
|
/ci |
Contributor
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12491
|
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#12491[✅] src/platform/plugins/shared/home/test/scout/api/playwright.config.ts (--arch stateful --domain classic): 30/30 tests passed. |
paulinashakirova
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Moves the flights sample data API coverage from the legacy FTR API integration suite into Scout/Playwright-based API tests for the Home plugin.
Changes:
- Removed the Home sample data API tests from the FTR
api_integrationsuite. - Added Scout API tests covering flights dataset list/install/uninstall and timestamp shifting via
?now=. - Introduced Scout Playwright config plus shared fixtures/constants for flights sample data assertions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/platform/test/api_integration/apis/index.ts | Removes the home API integration suite from the FTR runner. |
| src/platform/test/api_integration/apis/home/sample_data.ts | Deletes the legacy FTR sample data API tests (moved to Scout). |
| src/platform/plugins/shared/home/test/scout/api/tests/sample_data.spec.ts | Adds Scout API tests for flights sample data lifecycle + timestamp assertions + space coverage. |
| src/platform/plugins/shared/home/test/scout/api/playwright.config.ts | Adds Scout Playwright configuration for the new API test directory. |
| src/platform/plugins/shared/home/test/scout/api/fixtures/index.ts | Introduces shared Scout fixtures and re-exports constants for the tests. |
| src/platform/plugins/shared/home/test/scout/api/fixtures/constants.ts | Adds flights dataset constants (IDs, headers, timestamp span). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
- Changed comment from "ID regeneration + full lifecycle" to "ID preservation + full lifecycle" to better reflect the test's purpose and functionality.
Contributor
Author
|
/flaky scoutConfig:src/platform/plugins/shared/home/test/scout/api/playwright.config.ts:30 |
Contributor
Author
|
/ci |
Contributor
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12508
|
Contributor
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#12508[✅] src/platform/plugins/shared/home/test/scout/api/playwright.config.ts (--arch stateful --domain classic): 30/30 tests passed. |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
- Added detailed instructions for starting the server and running tests in the Playwright configuration file. - Updated comments in the constants file to improve clarity and removed outdated documentation. - Simplified the sample data test setup by removing unnecessary pre-clean and post-clean steps, ensuring a cleaner test environment.
Contributor
Author
|
/flaky scoutConfig:src/platform/plugins/shared/home/test/scout/api/playwright.config.ts:30 |
Contributor
Author
|
/ci |
Contributor
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#12540
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves [Scout] Move Home / Sample Data API from FTR to Scout issue.
This update enhances the testing framework for the flights dataset, ensuring robust coverage and validation of sample data APIs.