Skip to content

[Security Solution] Add rulesClient.bulkCreate(), with feedback from ResponseOps (including Wiring) #271722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sdesalas wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[Security Solution] Add rulesClient.bulkCreate(), with feedback from ResponseOps (including Wiring) #271722

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b7cfe02
Add rulesClient.bulkCreate(), optionally delaying rulesClient.bulkEna…
sdesalas May 13, 2026
b9e3b73
Incorporate feedback from alerting framework team
sdesalas May 14, 2026
0074370
Additional round of feedback. Move in-memory validation up-front befo…
sdesalas May 28, 2026
d6d1463
Review APM, move preValidate to bulk_create_rules for visibility in k…
sdesalas May 28, 2026
32cd9de
Optimize bulk task scheduling. Single task runs now, multiple tasks a…
sdesalas May 28, 2026
d9badae
Add recent changeTracking support
sdesalas May 28, 2026
9c80944
Add wiring for security detection rules
sdesalas May 28, 2026
5c3e2be
Changes from node scripts/eslint_all_files --no-cache --fix
kibanamachine May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion x-pack/platform/plugins/shared/alerting/common/rule_circuit_breaker_error_message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ const getBulkEnableRuleErrorSummary = () => {
});
};

const getBulkCreateRuleErrorSummary = () => {
return i18n.translate('xpack.alerting.ruleCircuitBreaker.error.bulkCreateSummary', {
defaultMessage: `Rules cannot be bulk created. The maximum number of runs per minute would be exceeded.`,
});
};

const getRuleCircuitBreakerErrorDetail = ({
interval,
intervalAvailable,
Expand Down Expand Up @@ -84,7 +90,7 @@ export const getRuleCircuitBreakerErrorMessage = ({
name?: string;
interval: number;
intervalAvailable: number;
action: 'update' | 'create' | 'enable' | 'bulkEdit' | 'bulkEnable';
action: 'update' | 'create' | 'enable' | 'bulkEdit' | 'bulkEnable' | 'bulkCreate';
rules?: number;
}) => {
let errorMessageSummary: string;
Expand All @@ -105,6 +111,9 @@ export const getRuleCircuitBreakerErrorMessage = ({
case 'bulkEnable':
errorMessageSummary = getBulkEnableRuleErrorSummary();
break;
case 'bulkCreate':
errorMessageSummary = getBulkCreateRuleErrorSummary();
break;
}

return `Error validating circuit breaker - ${errorMessageSummary} - ${getRuleCircuitBreakerErrorDetail(
Expand Down
Loading
Loading