[RnA] Simplify matcher context and Add Rule name to workflow payload by miguelmartin-elastic · Pull Request #271768 · elastic/kibana

miguelmartin-elastic · 2026-05-28T17:14:17Z

Summary

Closes https://github.com/elastic/rna-program/issues/517
Closes https://github.com/elastic/rna-program/issues/499

#517 — Simplify MatcherContext rule fields

Removes description, enabled, createdAt, and updatedAt from MatcherContextRule and MATCHER_CONTEXT_FIELDS. These fields have no use in matcher evaluation logic and add unnecessary noise.

#499 — Add rule metadata to dispatched workflow payload

Adds a rules: Record<ruleId, { name: string }> map to ActionPolicyWorkflowPayload. Workflows can now access rule names via {{ inputs.rules[episode.rule_id].name }} without extra lookups. Data is sourced from the existing state.rules already loaded by FetchRulesStep.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

…: description, enabled, createdAt, updatedAt

kdelemme

i think we can trim the Rule type too, and a few questions on where the rule map should be crafted and stored on? Might be pros/cons in both approach. what do you think?

kdelemme · 2026-05-28T17:26:42Z

 export interface Rule {
  id: RuleId;
  spaceId: string;
  kind: 'alert' | 'signal';
  name: string;
  description: string;
  tags: string[];
  enabled: boolean;
  createdAt: string;
  updatedAt: string;
 }


Can we simplify these as well? We probably don't need most of these fields?

Yep, totally. Done in 45a1572

kdelemme · 2026-05-28T17:27:47Z

 }

+export interface ActionPolicyWorkflowPayloadRule {
+  name: string;  


Should we add the tags as well?

Happy to add it, but leaning towards YAGNI for now — tags are already available in the matcher context for filtering. Open to adding if you see a concrete use case here 🤔

Tags could be useful for a message but let's wait i agree with you

kdelemme · 2026-05-28T17:36:32Z

 export interface Rule {
  id: RuleId;
  spaceId: string;
  kind: 'alert' | 'signal';


I think we only handle 'alert' kind so might not be useful to keep kind

Done in 45a1572 and 8cfa955

kdelemme · 2026-05-28T17:37:17Z

  policyId: ActionPolicyId;
  groupKey: Record<string, unknown>;
  episodes: AlertEpisode[];
+  rules: Record<RuleId, ActionPolicyWorkflowPayloadRule>;


If we trim Rule, can't we use Record<RuleId, Rule> directly?

Rule still has some other fields that we don't use in the payload: id, spaceId, tags. What I did instead was to make ActionPolicyWorkflowPayloadRule be a Pick type from Rule in d75f460 Lmkwyt

good 👍🏻

kdelemme · 2026-05-28T17:43:03Z

  }

  private async dispatchWorkflow(
    group: ActionGroup,


What if we make rules (the map one) directly part of the action group?

Nice. Done in 34426be

…m/miguelmartin-elastic/kibana into feat/simplify-matcher-context-517

kdelemme

I think we should not rebuild the whole rules map for every episode, build it incrementally

kdelemme · 2026-05-29T14:44:25Z

 export interface MatcherContextRule {
  id: string;
  name: string;
-  description: string;
  tags: string[];
-  enabled: boolean;
-  createdAt: string;
-  updatedAt: string;
 }


kdelemme · 2026-05-29T14:44:57Z

+  {
+    path: 'rules',
+    detail: 'Record<string, { name: string }>',
+    documentation:
+      'Rule metadata keyed by rule id. Covers all rules present in `episodes`. Access via `rules[episode.rule_id].name`.',
+  },


We are going to have some conflict when #271770 land :D

kdelemme · 2026-05-29T14:58:22Z

+    const group = groupMap.get(actionGroupId)!;
+    group.episodes.push(episode);
+    group.rules = buildRulesMap([...new Set(group.episodes.map((e) => e.rule_id))], rules);


Are we rebuilding the rules map every time?

I think we can optimize this (you can drop your helper buildRulesMap too)

const group = groupMap.get(actionGroupId)!; group.episodes.push(episode); const rule = rules?.get(episode.rule_id); if (rule) { group.rules[episode.rule_id] = { name: rule.name }; }

Good catch wizard 🧙‍♂️ Fixed in 9fcb0eb

kibanamachine · 2026-06-01T09:42:20Z

💚 Build Succeeded

Buildkite Build
Commit: b77c145
Storybooks Preview
Build duration: 64 mins

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alertingVTwo`	963.2KB	963.2KB	+34.0B

History

💛 Build #450448 was flaky 2740990
💛 Build #450355 was flaky 8cfa955
💔 Build #449857 failed a71ca54

miguelmartin-elastic added 2 commits May 28, 2026 14:09

remove unused rule fields from matcher context and suggestion service…

698aff1

…: description, enabled, createdAt, updatedAt

add rules map with rule names to the workflow payload

ae3a4ae

github-actions Bot added the author:actionable-obs PRs authored by the actionable obs team label May 28, 2026

miguelmartin-elastic added backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes labels May 28, 2026

Merge branch 'main' into feat/simplify-matcher-context-517

f36c3c9

miguelmartin-elastic marked this pull request as ready for review May 28, 2026 17:16

miguelmartin-elastic requested a review from a team as a code owner May 28, 2026 17:16

Changes from node scripts/check

a71ca54

kdelemme reviewed May 28, 2026

View reviewed changes

miguelmartin-elastic added 7 commits May 29, 2026 13:24

remove unused fields from Rule type

45a1572

move rules map to action group

34426be

cover with unit tests

43490b7

derive ActionPolicyWorkflowPayloadRule from Rule type

d75f460

run local checks

007eec5

Merge branch 'feat/simplify-matcher-context-517' of https://github.co…

0741212

…m/miguelmartin-elastic/kibana into feat/simplify-matcher-context-517

remove kind from store_execution_history_step

8cfa955

miguelmartin-elastic requested a review from kdelemme May 29, 2026 14:25

kdelemme requested changes May 29, 2026

View reviewed changes

enhance rule map building

9fcb0eb

miguelmartin-elastic requested a review from kdelemme May 29, 2026 15:49

kibanamachine and others added 2 commits May 29, 2026 16:04

Changes from node scripts/check

2740990

Merge branch 'main' into feat/simplify-matcher-context-517

b77c145

Conversation

miguelmartin-elastic commented May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kdelemme May 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kdelemme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 1, 2026

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

miguelmartin-elastic commented May 28, 2026 •

edited

Loading

kdelemme May 28, 2026 •

edited

Loading