Skip to content

[Agent Builder] Fix LLM assignment change not reflected without page refresh#271780

Closed
saikatsarkar056 wants to merge 7 commits into
elastic:mainfrom
saikatsarkar056:fix-agent-builder-llm-assignment-stale-ui
Closed

[Agent Builder] Fix LLM assignment change not reflected without page refresh#271780
saikatsarkar056 wants to merge 7 commits into
elastic:mainfrom
saikatsarkar056:fix-agent-builder-llm-assignment-stale-ui

Conversation

@saikatsarkar056
Copy link
Copy Markdown
Contributor

@saikatsarkar056 saikatsarkar056 commented May 28, 2026

Summary

When an admin changes the LLM model assignment for Agent Builder in the Feature Settings page, the open Agent Builder session kept showing the old model until the user refreshed the entire page. This was confusing because the setting appeared saved but had no visible effect in the current session.

Screen Recording

Screen.Recording.2026-05-28.at.3.16.00.PM.mov

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

Release note

Fixes Agent Builder not reflecting LLM model assignment changes made in Feature Settings without a full page refresh.

@saikatsarkar056 saikatsarkar056 marked this pull request as ready for review May 28, 2026 22:41
@saikatsarkar056 saikatsarkar056 requested review from a team as code owners May 28, 2026 22:41
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 28, 2026

💔 Build Failed

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
agentBuilder 1.9MB 1.9MB +177.0B
searchInferenceEndpoints 235.8KB 235.9KB +39.0B
total +216.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
searchInferenceEndpoints 9.0KB 9.3KB +278.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
searchInferenceEndpoints 2 1 -1

Total ESLint disabled count

id before after diff
searchInferenceEndpoints 2 1 -1

History

cc @saikatsarkar056

Copy link
Copy Markdown
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution adds a permanent subscription on every page where the connector_selector is present, but the scenario it's checking for is exceedingly rare: having the conversation sidebar open, with a connector_selector, and editing the feature settings list.

I would rather solve this by forcing a page reload, or just ignore this edge case and let it be a little weird.

@saikatsarkar056
Copy link
Copy Markdown
Contributor Author

Thanks, @sphilipse. Agreed that this is a very rare case. Let's ignore this. I will close the Pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants