Skip to content

[Embeddable] embeddable schema cache #271959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nreese merged 2 commits into from
May 29, 2026
Merged

[Embeddable] embeddable schema cache #271959

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d523f5
[Embeddable] embeddable schema cache
nreese May 29, 2026
9ca50df
clean up
nreese May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/platform/plugins/shared/embeddable/server/embeddable_transforms/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,26 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

import type { ObjectType } from '@kbn/config-schema';
import type { ObjectType, Type } from '@kbn/config-schema';
import type { getDrilldownRegistry } from '../drilldowns/registry';
import type { EmbeddableServerDefinition } from './types';

export function getEmbeddableServerRegistry(
drilldownRegistry: ReturnType<typeof getDrilldownRegistry>
) {
const registry: { [key: string]: EmbeddableServerDefinition<any, any> } = {};
const schemaCache: Record<string, Type<object> | undefined> = {};

function getCachedSchema(type: string) {
if (schemaCache[type]) {
return schemaCache[type];
}

const { getSchema } = registry[type] ?? {};
const schema = getSchema?.(drilldownRegistry.getSchema);
schemaCache[type] = schema;
return schema;
}

return {
registerEmbeddableServerDefinition: (
Expand All @@ -30,7 +42,7 @@ export function getEmbeddableServerRegistry(
getAllEmbeddableSchemas: () => {
const schemas: { [key: string]: { schema: ObjectType; title: string } } = {};
Object.entries(registry).forEach(([type, definition]) => {
const schema = definition?.getSchema?.(drilldownRegistry.getSchema);
const schema = getCachedSchema(type);
if (schema) {
schemas[type] = {
schema: schema as ObjectType,
Expand All @@ -41,10 +53,11 @@ export function getEmbeddableServerRegistry(
return schemas;
},
getEmbeddableTransforms: (type: string) => {
const { getTransforms, getSchema, throwOnUnmappedPanel } = registry[type] ?? {};
const { getTransforms, throwOnUnmappedPanel } = registry[type] ?? {};
const schema = getCachedSchema(type);
return {
...getTransforms?.(drilldownRegistry.transforms),
...(getSchema ? { schema: getSchema(drilldownRegistry.getSchema) } : {}),
...(schema ? { schema } : {}),
...(typeof throwOnUnmappedPanel === 'boolean' ? { throwOnUnmappedPanel } : {}),
};
},
Expand Down
Loading