[9.4] Attempt to solve timeout issue when loading legacy visualizations dashboard (#271948)#271986
Merged
Merged
Conversation
…hboard (elastic#271948) Closes elastic#271816 ## Summary ### Theory [elastic#271520](elastic#271520) exposed the issue because it changed the timing of FTR’s first authenticated navigation. Before that PR, common.navigateToApp('dashboards') hit the login page, filled the UI form, waited for Kibana chrome, then navigated to the app URL again. That slower, multi-step flow gave the Dashboards app more time to settle on #/list before the next call to loadDashboardInEditMode(). After that PR, login is done by API and cookie injection. loginIfPrompted() now injects the sid cookie and navigates directly to the target app URL. That is faster and skips some of the old UI-login waits. So the test reaches: ``` dashboard.initTests() -> dashboard.loadDashboardInEditMode() -> gotoDashboardLandingPage() ``` sooner, while the Dashboards route can still be settling. The underlying bug was already in gotoDashboardLandingPage(): it checks the URL once, and if it does not see dashboards#/list at that exact moment, it assumes it must be inside a dashboard and waits for the in-dashboard breadcrumb. (cherry picked from commit 5ed988c)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
💚 Build Succeeded
Metrics [docs]
History
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.4:Questions ?
Please refer to the Backport tool documentation