[One workflow] Instrument event-driven execute modal telemetry#271999
Open
yngrdyn wants to merge 6 commits into
Open
[One workflow] Instrument event-driven execute modal telemetry#271999yngrdyn wants to merge 6 commits into
yngrdyn wants to merge 6 commits into
Conversation
botelastic
Bot
added
the
Team:One Workflow
yngrdyn
added
backport:skip
…b.com:yngrdyn/kibana into event-driven-triggers_testing-modal_telemetry
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Page load bundle
History
cc @yngrdyn |
rosomri
approved these changes
Jun 1, 2026
Contributor
rosomri
left a comment
rosomri
left a comment
There was a problem hiding this comment.
approved with one comment
| if (enabledChanged) { | ||
| const enabledValue = workflowUpdate.enabled ?? workflowDefinition?.enabled; | ||
| if (enabledValue !== undefined) { | ||
| const { hasCustomEventTrigger } = extractWorkflowMetadata(workflowDefinition); |
Contributor
There was a problem hiding this comment.
This will under-report hasCustomEventTrigger for workflow-list enable/disable actions. Those callers don’t pass workflowDefinition, so extractWorkflowMetadata(workflowDefinition) falls back to false even for event-driven workflows. Could we pass the definition through the list/bulk toggle mutations, or pass this boolean explicitly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to https://github.com/elastic/security-team/issues/16717.
Summary
Extends existing telemetry so we can measure whether authors test event-driven workflows before enabling them, and which run-input path they use in the execute modal (event selection, manual JSON, or historical replay).
Adds
hasCustomEventTriggerto execution and lifecycle events, documentseventas a validtriggerTabvalue, and wires reporting from test runs, list runs, and enable/disable actions.Motivation
Product questions we could not answer reliably before:
Telemetry changes
New field:
hasCustomEventTrigger(boolean, optional)Present when the workflow definition at action time includes at least one extension trigger type (non-built-in
type, same semantics as the Event tab).workflows_workflow_test_run_initiatedworkflows_workflow_run_initiatedworkflows_workflow_enabled_state_changedenabled)Updated field:
triggerTab(keyword, optional)Schema descriptions now include
eventalongsidemanual,alert,index, andhistorical.Metadata source
hasCustomEventTriggeris derived viaextractWorkflowMetadata().