[Synthetics] Migrate monitor create/edit API tests to Scout (batch 1)#272008
Draft
shahzad31 wants to merge 2 commits into
Draft
[Synthetics] Migrate monitor create/edit API tests to Scout (batch 1)#272008shahzad31 wants to merge 2 commits into
shahzad31 wants to merge 2 commits into
Conversation
Migrates the synthetics monitor create/edit API integration tests from the deployment-agnostic FTR suite to Scout API tests (part of elastic#263519): - create_monitor (UI create + space namespace) - create_monitor_public_api / _private_location - edit_monitor_public_api / _private_location Shared helpers (omitMonitorKeys, parseMonitorResponse, editMonitor, LOCAL_PUBLIC_LOCATION, http_monitor fixture) are added to the Scout api fixtures. The FTR create_monitor.ts is retained as a helpers-only module because addMonitorAPIHelper/omitMonitorKeys are still used by unmigrated FTR suites; the migrated loadTestFile entries are replaced with "migrated to Scout" pointers. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
Contributor
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
History |
This was referenced May 29, 2026
The serverless observability_complete Scout config only set xpack.uptime.service.manifestUrl, so no Elastic-managed `dev` location was created (getServiceLocations requires service.devUrl). The migrated monitor create/edit public-API specs failed on serverless with "Elastic managed Location(s) 'dev' not found". Add devUrl/username/password to match the stateful Scout base config and the FTR deployment-agnostic serverless base config. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #263519 (Actionable Observability FTR → Scout migration). This is batch 1 of the synthetics deployment-agnostic API suite migration: monitor create/edit tests.
Migrated FTR suites → Scout API specs (
x-pack/solutions/observability/plugins/synthetics/test/scout/api/tests/):create_monitor.ts(suite)create_monitor.spec.tscreate_monitor_public_api.tscreate_monitor_public_api.spec.tscreate_monitor_public_api_private_location.tscreate_monitor_public_api_private_location.spec.tsedit_monitor_public_api.tsedit_monitor_public_api.spec.tsedit_monitor_public_api_private_location.tsedit_monitor_public_api_private_location.spec.tsNotes
omitMonitorKeys/keyToOmitList(reusing the plugin'stransformPublicKeys/removeMonitorEmptyValues),parseMonitorResponse, aneditMonitorPUT helper,LOCAL_PUBLIC_LOCATION,SYNTHETICS_MONITOR_SO_TYPES, and a typedhttp_monitorfixture.get_filtersScout spec and the FTR suite's flake-avoidance design.create_monitor.tsis retained as a helpers-only module becauseaddMonitorAPIHelper/omitMonitorKeysare still imported by unmigrated FTR suites (enable_default_alerting,get_monitor,sync_global_params,create_monitor_private_location,edit_private_location,get_private_location_monitors). MigratedloadTestFileentries are replaced withmigrated to Scoutpointers.@local-stateful-classic+@local-serverless-observability_complete(preserving the FTRskipCloud/skipMKIintent), consistent with the already-migratedget_filters/synthetics_enablementspecs.Test plan
node scripts/type_check --project x-pack/solutions/observability/plugins/synthetics/tsconfig.jsonscout.js start-server --arch stateful --domain classic+playwright test --project=local)observability_complete) local run — pending (blocked locally by a port conflict from leftover containers; logic is not deployment-specific)Made with Cursor