[Uptime] Migrate functional_with_es_ssl alert tests to Scout#272030
Draft
shahzad31 wants to merge 1 commit into
Draft
[Uptime] Migrate functional_with_es_ssl alert tests to Scout#272030shahzad31 wants to merge 1 commit into
shahzad31 wants to merge 1 commit into
Conversation
The observability `functional_with_es_ssl` FTR config only existed to run two legacy uptime alerting UI suites (`alert_flyout` and `simple_down_alert`). These are migrated to the existing uptime Scout UI suite and the standalone FTR config is removed: - Add `monitor_status_alert_flyout.spec.ts` (monitor status rule flyout). - Add `simple_down_alert.spec.ts` (enable/disable simple status alert from the monitor list, with a connector created via API instead of a preconfigured one). - The TLS alert flyout block is already covered by `tls_alert_flyout.spec.ts`, so it is dropped rather than migrated. - Delete `x-pack/solutions/observability/test/functional_with_es_ssl/` and its CI manifest entry + stale CODEOWNERS lines. Co-authored-by: Cursor <cursoragent@cursor.com>
shahzad31
added
the
release_note:skip
github-actions
Bot
added
the
author:actionable-obs
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The observability
functional_with_es_sslFTR config existed solely to run two legacy uptime alerting UI suites (apps/uptime/alert_flyout.tsandapps/uptime/simple_down_alert.ts). This migrates the still-needed coverage to the existing uptime Scout UI suite and removes the standalone FTR config.monitor_status_alert_flyout.spec.ts— opens the monitor status rule flyout from the rules app and verifies the form renders (migrated from theoverview page alert flyout controlsblock).simple_down_alert.spec.ts— enables/disables a simple status alert from the monitor list and verifies the created rule via API. The connector is created via the actions API in setup instead of relying on a preconfiguredmy-slack1connector.tls_alert_flyout.spec.ts.x-pack/solutions/observability/test/functional_with_es_ssl/entirely, plus its entry in.buildkite/ftr-manifests/ftr_oblt_stateful_configs.ymland the now-stale.github/CODEOWNERSlines..meta/ui/standard.json.Net: -447 / +181 lines, one fewer stateful FTR config in CI.
Test plan
node scripts/eslinton the new specs — cleannode scripts/type_check --project .../uptime/test/scout/ui/tsconfig.json— passessetup-local+MonitorStatusFlyoutInAlertingApp+SimpleDownAlert)Made with Cursor