[Scout] Add missing globalTeardownHook for Discover, Discover Enhanced, and Streams App#272042
Open
steliosmavro wants to merge 2 commits into
Open
Conversation
…d, and Streams App Resets the `discover.isEsqlDefault` feature flag override (null removes the override and restores the registered default) and deletes the custom `test-metrics-*` indices created by Discover's setup. Disables streams after Streams App tests finish.
steliosmavro
added
release_note:skip
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
global.teardown.tsfiles for three Scout parallel test suites that were setting cluster-wide state in their setup hooks without cleaning it up afterward. Teardown is intentionally opt-in in Scout (file presence is what enables it), so these suites were leaving dirty state behind for any subsequent config sharing the same cluster.Changes
discover.isEsqlDefaultfeature flag override (passesnullto remove the override and restore the registered default) and deletes the customtest-metrics-experience/test-metrics-experience-otherindices created by the setup hookdiscover.isEsqlDefaultfeature flag overrideapiServices.streams.disable()to undo theenable()called in setup