[KQL] Migrate value suggestions API tests from FTR to Scout#272044
Draft
shahzad31 wants to merge 1 commit into
Draft
[KQL] Migrate value suggestions API tests from FTR to Scout#272044shahzad31 wants to merge 1 commit into
shahzad31 wants to merge 1 commit into
Conversation
Move the platform `apis/suggestions` FTR API integration suite (value suggestions / autocomplete endpoint) into a Scout API suite co-located with the route owner, the `kql` plugin. This aligns test ownership with code ownership (`@elastic/kibana-presentation`) via CODEOWNERS path inheritance, and removes a legacy stateful-only FTR config. - Add `src/platform/plugins/shared/kql/test/scout/api` (12 tests across non-time-based + time-based specs), porting all cases 1:1. - Delete `src/platform/test/api_integration/apis/suggestions` and drop it from the api_integration index. - Register `kql` in `.buildkite/scout_ci_config.yml` (done by generator). - Remove the now-stale CODEOWNERS entry for the old FTR path. Co-authored-by: Cursor <cursoragent@cursor.com>
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the platform
apis/suggestionsFTR API-integration suite (thevalue suggestions / autocomplete endpoint,
POST /internal/kibana/suggestions/values/{index})to a Scout API suite, co-located with the route owner — the
kqlplugin.This:
@elastic/actionable-obs-teampurely as a best-effort backfill artifact(#200950), even though the
route lives in
kql. Placing the tests undersrc/platform/plugins/shared/kql/test/scout/apimakes them auto-inheritthe
kqlCODEOWNERS entry (@elastic/kibana-presentation).What changed
src/platform/plugins/shared/kql/test/scout/api— a Scout API suite(
@kbn/scout) with all 12 cases ported 1:1, split across:value_suggestions.spec.ts(8) — non-time-based behavior overbasic_index(
terms_agg/terms_enum, special characters, nested fields, 404/400 cases).value_suggestions_time_filters.spec.ts(4) — time-based filter behavior overlogstash-*(document-level vs index-level filtering).src/platform/test/api_integration/apis/suggestionsand removed itfrom the
api_integrationindex.kqlin.buildkite/scout_ci_config.yml(done by the generator).Notes
returned/awaited its supertest chain, so its assertion couldn't fail. The Scout
version awaits it properly.
esArchiverfixture only ingests data (nounload), so cleanup onlyremoves the imported Kibana saved objects.
Test plan
node scripts/type_check --project src/platform/plugins/shared/kql/test/scout/api/tsconfig.jsonnode scripts/eslinton changed filesnode scripts/scout.js run-tests --arch stateful --domain classic --config src/platform/plugins/shared/kql/test/scout/api/playwright.config.ts→ 12/12 passednode scripts/check.js --scope branch→ lint ✓, jest (no affected configs), tsc ✓ (47 projects)Made with Cursor