Skip to content

[Chrome Next] Remove AppHeaderWithFallback #272087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dosant wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −95
Open

[Chrome Next] Remove AppHeaderWithFallback #272087

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/core/packages/chrome/app-header/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ the page cannot safely own the header placement yet.
Use `AppHeader` when the page can render its header inline. This is the preferred model for pages
that own their title, back target, tabs, badges, and app menu locally.

Use `AppHeaderWithFallback` when the same page still needs a classic `EuiPageHeader` fallback while
Chrome Next is disabled.

Use `ChromeAppHeaderRegistration` when Chrome should own the top-bar slot. This keeps migration
small for pages with sticky or shared top-nav constraints while still using the shared header view.

Expand Down Expand Up @@ -50,7 +47,7 @@ different buckets while the migration is in progress:

| Bucket | Preferred API | When to use |
|---|---|---|
| Inline-ready | `AppHeader` or `AppHeaderWithFallback` | The page can colocate header state with its React tree. |
| Inline-ready | `AppHeader` | The page can colocate header state with its React tree. |
| Chrome-owned transitional | `ChromeAppHeaderRegistration` | Chrome should own the top-bar slot while the route keeps existing layout constraints. |
| Fallback-only | Legacy Chrome state | Temporary safety net for routes that have not explicitly migrated. |

Expand Down
3 changes: 1 addition & 2 deletions src/core/packages/chrome/app-header/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,10 @@
* License v3.0 only", or the "Server Side Public License, v 1".
*/

export { AppHeaderWithFallback, AppHeader } from './src';
export { AppHeader } from './src';
export { AppHeaderView, ChromeAppHeaderRegistration, useChromeAppHeaderRegistration } from './src';
export type { AppHeaderViewProps, AppHeaderConfig } from './src';
export type {
AppHeaderWithFallbackProps,
AppHeaderProps,
AppHeaderBack,
AppHeaderBadge,
Expand Down
87 changes: 0 additions & 87 deletions src/core/packages/chrome/app-header/src/app_header_with_fallback.tsx
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/core/packages/chrome/app-header/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@ export type {
AppHeaderPadding,
AppHeaderConfig,
} from './types';
export type { AppHeaderWithFallbackProps } from './app_header_with_fallback';
export { AppHeaderWithFallback } from './app_header_with_fallback';
Loading