Skip to content

remove panel action FTR tests#273345

Merged
nreese merged 2 commits into
elastic:mainfrom
nreese:remove_panel_action_tests
Jun 16, 2026
Merged

remove panel action FTR tests#273345
nreese merged 2 commits into
elastic:mainfrom
nreese:remove_panel_action_tests

Conversation

@nreese

@nreese nreese commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Part of #271763

src/platform/test/plugin_functional/test_suites/panel_actions test that actions registered to trigger ON_OPEN_PANEL_MENU are displayed in panel context menu. This is better tested at the unit level and already covered at the integration level. Most dashboard tests already test specific context menu actions so a test is not needed to verify actions registed to trigger ON_OPEN_PANEL_MENU are displayed in panel context menu.

PR also removes kbn_sample_panel_action plugin since it was only used by this FTR test.

@nreese

nreese commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/ci

@nreese

nreese commented Jun 15, 2026

Copy link
Copy Markdown
Contributor Author

/ci

@kibanamachine

Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Serverless Entity Analytics - Security Cypress Tests #1 / Entity Analytics Watchlists Management Page deletes a watchlist via the actions menu deletes a watchlist via the actions menu
  • [job] [logs] Scout Lane #13 - stateful-classic / default / local-stateful-classic - Lens Convert to ES|QL button - should not display button for inline visualizations when feature flag is set to false

Metrics [docs]

✅ unchanged

History

@nreese nreese marked this pull request as ready for review June 15, 2026 15:24
@nreese nreese requested review from a team as code owners June 15, 2026 15:24
@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// backport:version Backport to applied version labels v9.5.0 v9.4.3 v8.19.17 labels Jun 15, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/kibana-presentation (Team:Presentation)

@nreese nreese added the release_note:skip Skip the PR/issue when compiling release notes label Jun 15, 2026
@nreese nreese mentioned this pull request Jun 15, 2026
18 tasks

@dmlemeshko dmlemeshko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Heenawter Heenawter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@nreese nreese added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels and removed release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels labels Jun 16, 2026
@nreese nreese merged commit a408728 into elastic:main Jun 16, 2026
161 checks passed
@kibanamachine

Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.19, 9.4

https://github.com/elastic/kibana/actions/runs/27602949057

delanni pushed a commit to delanni/kibana that referenced this pull request Jun 16, 2026
Part of elastic#271763

src/platform/test/plugin_functional/test_suites/panel_actions test that
actions registered to trigger `ON_OPEN_PANEL_MENU` are displayed in
panel context menu. This is better tested at the unit level and already
covered at the integration level. Most dashboard tests already test
specific context menu actions so a test is not needed to verify actions
registed to trigger `ON_OPEN_PANEL_MENU` are displayed in panel context
menu.

PR also removes kbn_sample_panel_action plugin since it was only used by
this FTR test.
@kibanamachine

Copy link
Copy Markdown
Contributor

💔 All backports failed

Status Branch Result
8.19 Backport failed because of merge conflicts
9.4 Backport failed because of merge conflicts

You might need to backport the following PRs to 9.4:
- [One Workflow] Fix the variable type detection within liquidjs for loops (#270596)

Manual backport

To create the backport manually run:

node scripts/backport --pr 273345

Questions ?

Please refer to the Backport tool documentation

@nreese nreese removed the v8.19.17 label Jun 16, 2026
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2026
@kibanamachine

Copy link
Copy Markdown
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 273345 locally
cc: @nreese

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 17, 2026
VladimirFilonov pushed a commit to VladimirFilonov/kibana that referenced this pull request Jun 17, 2026
Part of elastic#271763

src/platform/test/plugin_functional/test_suites/panel_actions test that
actions registered to trigger `ON_OPEN_PANEL_MENU` are displayed in
panel context menu. This is better tested at the unit level and already
covered at the integration level. Most dashboard tests already test
specific context menu actions so a test is not needed to verify actions
registed to trigger `ON_OPEN_PANEL_MENU` are displayed in panel context
menu.

PR also removes kbn_sample_panel_action plugin since it was only used by
this FTR test.
flash1293 pushed a commit to flash1293/kibana that referenced this pull request Jun 23, 2026
Part of elastic#271763

src/platform/test/plugin_functional/test_suites/panel_actions test that
actions registered to trigger `ON_OPEN_PANEL_MENU` are displayed in
panel context menu. This is better tested at the unit level and already
covered at the integration level. Most dashboard tests already test
specific context menu actions so a test is not needed to verify actions
registed to trigger `ON_OPEN_PANEL_MENU` are displayed in panel context
menu.

PR also removes kbn_sample_panel_action plugin since it was only used by
this FTR test.
logeekal pushed a commit to logeekal/kibana that referenced this pull request Jun 25, 2026
Part of elastic#271763

src/platform/test/plugin_functional/test_suites/panel_actions test that
actions registered to trigger `ON_OPEN_PANEL_MENU` are displayed in
panel context menu. This is better tested at the unit level and already
covered at the integration level. Most dashboard tests already test
specific context menu actions so a test is not needed to verify actions
registed to trigger `ON_OPEN_PANEL_MENU` are displayed in panel context
menu.

PR also removes kbn_sample_panel_action plugin since it was only used by
this FTR test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels backported release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v9.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants