[Controls] Clear indicate related panel state when entering/exiting edit mode or flyout by Zacqary · Pull Request #273760 · elastic/kibana

Zacqary · 2026-06-17T15:08:49Z

Summary

Quick UX fix followup to #264426. User reported confusion when:

Editing a panel
Clicking an ES|QL control to indicate related panels
Closing the edit window and seeing all the related panels remain highlighted

This is because the relatedPanelsIndicatorId is set independently of opening or closing an edit flyout. This PR makes sure to clear the indicator ID when entering or leaving an edit flyout.

…n edit flyout

infra-vault-gh-plugin-prod · 2026-06-17T15:08:54Z

Pinging @elastic/kibana-presentation (Team:Presentation)

coderabbitai · 2026-06-17T19:36:57Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9a5b1d73-c87f-425f-bfbb-ff5a5600ecad

📥 Commits

Reviewing files that changed from the base of the PR and between 8e85b96 and f45cf6f.

📒 Files selected for processing (4)

src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.ts
src/platform/plugins/shared/dashboard/public/dashboard_api/track_overlay.ts
src/platform/plugins/shared/dashboard/public/dashboard_api/track_panel.test.ts
src/platform/plugins/shared/dashboard/public/dashboard_api/track_panel.ts

📝 Walkthrough

Walkthrough

initializeTrackPanel gains a viewMode$: BehaviorSubject<ViewMode> parameter; the combineLatest blur computation now returns empty results when viewMode is not 'edit', suppressing panel blur outside edit mode. initializeTrackOverlay's signature changes from a single setFocusedPanelId callback to a destructured object that also includes setRelatedPanelsIndicatorId; both clearOverlays (overlay close) and the overlay-open path now call setRelatedPanelsIndicatorId(undefined) to prevent related-panel indicator state from persisting. getDashboardApi wiring is updated to forward viewModeManager.api.viewMode$ to initializeTrackPanel and pass the full trackPanel.api object to initializeTrackOverlay.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Heenawter

Code review + tested locally. Left a few nits, but overall the fix is straightforward

Heenawter · 2026-06-17T20:10:58Z

+    // Clear related panels indicator ID when closing overlays as well. If the user is editing a panel
+    // and selects a control to indicate its related panels, then exits edit mode, they're probably thinking of
+    // the indication state to be part of the edit operation and expect it to clear
+    setRelatedPanelsIndicatorId(undefined);


nit I think this comment is good enough but 🤷

Suggested change

// Clear related panels indicator ID when closing overlays as well. If the user is editing a panel

// and selects a control to indicate its related panels, then exits edit mode, they're probably thinking of

// the indication state to be part of the edit operation and expect it to clear

setRelatedPanelsIndicatorId(undefined);

// Clear related panels indicator ID when closing overlays as well

Heenawter · 2026-06-17T20:12:04Z

Maybe worth adding a unit test for the view mode case?

kibanamachine · 2026-06-17T22:56:00Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6e9a1f2
Build duration: 67 mins

Failed CI Steps

Test Failures

[job] [logs] Jest Tests #2 / AssetDocumentTab should select json tab when clicked
[job] [logs] FTR Configs #133 / integrations For each artifact list under management When on the Event Filters entries list should be able to update an existing Event Filters entry
[job] [logs] Scout Lane #5 - stateful-classic / default / local-stateful-classic - APM integration not installed but setup completed - Admin user
[job] [logs] Scout Lane #6 - stateful-classic / default / local-stateful-classic - Bulk add alerts to chat - should disable the "Add to chat" bulk action when all alerts are selected via the query button
[job] [logs] Scout Lane #6 - stateful-classic / default / local-stateful-classic - Bulk add alerts to chat - should open agent builder conversation with attachment chip and pre-filled prompt, and send multiple alerts to the LLM
[job] [logs] Scout Lane #5 - stateful-classic / default / local-stateful-classic - Collector integration is not installed - collector integration missing
[job] [logs] Scout Lane #5 - stateful-classic / default / local-stateful-classic - Profiling is setup and data is loaded - Admin user
[job] [logs] Scout Lane #1 - stateful-classic / default / local-stateful-classic - Stream data routing - previewing data - should show preview during rule creation

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dashboard`	1.1MB	1.1MB	+88.0B

History

💛 Build #455876 was flaky f5b9b6f
💛 Build #455834 was flaky f45cf6f
💔 Build #455744 failed 0173fcb
💔 Build #455637 failed 8b0b400

…dit mode or flyout (elastic#273760) ## Summary Quick UX fix followup to elastic#264426. User reported confusion when: 1. Editing a panel 2. Clicking an ES|QL control to indicate related panels 3. Closing the edit window and seeing all the related panels remain highlighted This is because the `relatedPanelsIndicatorId` is set independently of opening or closing an edit flyout. This PR makes sure to clear the indicator ID when entering or leaving an edit flyout.

[Controls] Clear indicate related panel state when entering/exiting a…

8b0b400

…n edit flyout

Zacqary requested a review from a team as a code owner June 17, 2026 15:08

Heenawter reviewed Jun 17, 2026

View reviewed changes

Comment thread src/platform/plugins/shared/dashboard/public/dashboard_api/get_dashboard_api.ts

Zacqary added 2 commits June 17, 2026 11:55

Reset blurred panels when leaving edit mode

0b53240

Consolidate viewmode guard in trackpanel

d76c6c1

Zacqary changed the title ~~[Controls] Clear indicate related panel state when entering/exiting an edit flyout~~ [Controls] Clear indicate related panel state when entering/exiting edit mode or flyout Jun 17, 2026

Zacqary and others added 2 commits June 17, 2026 11:58

Merge branch 'main' into related-panel-highlight-edit-fix

0173fcb

Fix tests

f45cf6f

Zacqary requested a review from Heenawter June 17, 2026 19:27

Heenawter approved these changes Jun 17, 2026

View reviewed changes

Add view mode switch test, shorten comment

f5b9b6f

Zacqary enabled auto-merge (squash) June 17, 2026 20:53

Merge branch 'main' into related-panel-highlight-edit-fix

6e9a1f2

Zacqary merged commit f6c49cb into elastic:main Jun 17, 2026
30 checks passed

kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Jun 17, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Controls] Clear indicate related panel state when entering/exiting edit mode or flyout#273760

[Controls] Clear indicate related panel state when entering/exiting edit mode or flyout#273760
Zacqary merged 7 commits into
elastic:mainfrom
Zacqary:related-panel-highlight-edit-fix

Zacqary commented Jun 17, 2026

Uh oh!

infra-vault-gh-plugin-prod Bot commented Jun 17, 2026

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 17, 2026

Walkthrough

Uh oh!

Heenawter left a comment

Uh oh!

Heenawter Jun 17, 2026

Uh oh!

Heenawter Jun 17, 2026

Uh oh!

kibanamachine commented Jun 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Zacqary commented Jun 17, 2026

Summary

Uh oh!

infra-vault-gh-plugin-prod Bot commented Jun 17, 2026

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 17, 2026

Walkthrough

Uh oh!

Heenawter left a comment

Choose a reason for hiding this comment

Uh oh!

Heenawter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

Heenawter Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 17, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants