[ES|QL] [Controls] Fix field variable suggestions#273844
Merged
Heenawter merged 15 commits intoJun 22, 2026
Merged
Conversation
Heenawter
added
regression
release_note:fix
Team:Presentation
Heenawter
changed the title
Heenawter
changed the title
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
davismcphee
approved these changes
Jun 20, 2026
davismcphee
left a comment
davismcphee
left a comment
Contributor
There was a problem hiding this comment.
Code-only review, Data Discovery changes LGTM 👍 Not sure if there was anything specific I should've tested, but looks like just a new query prop being passed now.
Contributor
|
Thanks @Heenawter 🙌 |
Contributor
Author
Sorry @davismcphee! Should have included testing instructions + a video for Discover in the PR description 🙈 In summary, by providing the query to the control group renderer, we can properly derive which field suggestions to show. Before Screen.Recording.2026-06-22.at.8.39.52.AM.movAfter Screen.Recording.2026-06-22.at.8.43.01.AM.mov |
Zacqary
approved these changes
Jun 22, 2026
Zacqary
left a comment
Zacqary
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock, I think we could make this code a bit more functional though
Zacqary
reviewed
Jun 22, 2026
Zacqary
suggested changes
Jun 22, 2026
Zacqary
reviewed
Jun 22, 2026
Zacqary
approved these changes
Jun 22, 2026
Zacqary
left a comment
Zacqary
left a comment
Contributor
There was a problem hiding this comment.
Approving to unblock, just one nit to clean up the function further
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @Heenawter |
Contributor
|
Starting backport for target branches: 9.4 |
Contributor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Heenawter
added
backport:skip
flash1293
pushed a commit
to flash1293/kibana
that referenced
this pull request
Jun 23, 2026
Closes elastic#268695 ## Summary This PR fixes the suggestions when editing field variable controls for both Dashboard and Discover. For Dashboard, it does so by determining the related query **on runtime** when the editor is opened, making use of the new `relatedPanels$` system that was introduced in elastic#264426. It loops through all the children that are related, and it returns the query of the **first one** that uses it. For Discover, we provide the ES|QL query via the parent, and determine whether it is related from that. If the parent's and/or related child's ES|QL query references the given variable, the field suggestions will be populated. **Before** https://github.com/user-attachments/assets/e6043228-2ea6-463f-9761-13e772e9a149 **After** https://github.com/user-attachments/assets/566f3720-abe2-4400-ba3e-3813606874de ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268695
Summary
This PR fixes the suggestions when editing field variable controls for both Dashboard and Discover.
For Dashboard, it does so by determining the related query on runtime when the editor is opened, making use of the new
relatedPanels$system that was introduced in #264426. It loops through all the children that are related, and it returns the query of the first one that uses it. For Discover, we provide the ES|QL query via the parent, and determine whether it is related from that. If the parent's and/or related child's ES|QL query references the given variable, the field suggestions will be populated.Before
Screen.Recording.2026-06-19.at.2.16.42.PM.mov
After
Screen.Recording.2026-06-19.at.2.17.39.PM.mov
Checklist
release_note:*label is applied per the guidelinesbackport:*labels.