Skip to content

Breaking changes for 9.0 #17380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 2, 2025
Merged

Breaking changes for 9.0 #17380

merged 8 commits into from
Apr 2, 2025

Conversation

robbavey
Copy link
Member

@robbavey robbavey commented Mar 20, 2025 •
edited
Loading

Breaking changes document for 9.0,

Closes: #16722

@mergify Mergify
Copy link

mergify bot commented Mar 20, 2025

This pull request does not have a backport label. Could you fix it @robbavey? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

3 similar comments
@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

@robbavey robbavey force-pushed the breaking_changes_9 branch from fd3ae36 to 18e7300 Compare March 21, 2025 22:23
@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

@robbavey robbavey marked this pull request as ready for review March 26, 2025 14:52
@karenzone karenzone self-requested a review March 27, 2025 15:16
@karenzone karenzone added docs backport-9.0 Automated backport to the 9.0 branch with mergify labels Mar 27, 2025
karenzone
karenzone reviewed Mar 27, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline for consideration and/or discussion.

@github-actions GitHub Actions
Copy link
Contributor

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

karenzone
karenzone reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files have been moved around and some redirects removed.
Please remove /ingestion-tools/ from all Agent doc paths. That's the source of the new failures.

(GitHub won't let me fix paths as a suggestion because this is not "changed content.") A rebase might fix?

docs/release-notes/breaking-changes.md Outdated
Comment on lines 251 to 248
{{ls}} on Docker, the base image has been changed from Ubuntu to UBI9. If you create a Docker image based on the
{{ls}} image, and rely on it being Ubuntu based, you will need to change your derived image to take account of this
change.

For more information, check [#16599](https://github.com/elastic/logstash/pull/16599)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the example. Please consider taking the tweaks in my earlier suggestion, and then adding the example to that. Starting on a new line, please.

@robbavey robbavey changed the title WIP 9.0 Breaking changes Breaking changes for 9.0 Apr 1, 2025
@robbavey robbavey force-pushed the breaking_changes_9 branch from 185ba4e to c91698b Compare April 1, 2025 19:12
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

📃 DOCS PREVIEW ✨ https://logstash_bk_17380.docs-preview.app.elstc.co/diff

karenzone
karenzone approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Lots of good stuff in here. Thanks!

@robbavey robbavey merged commit 3c6cbbf into elastic:main Apr 2, 2025
8 checks passed
mergify bot pushed a commit that referenced this pull request Apr 2, 2025
@robbavey @mergify
Breaking changes for 9.0 (#17380)
d63edce 
(cherry picked from commit 3c6cbbf)
@mergify mergify bot mentioned this pull request Apr 2, 2025
Merged
robbavey added a commit that referenced this pull request Apr 2, 2025
@mergify @robbavey
Breaking changes for 9.0 (#17380) (#17480)
0d162a5 
(cherry picked from commit 3c6cbbf)

Co-authored-by: Rob Bavey <[email protected]>
This was referenced Apr 2, 2025
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport-9.0 Automated backport to the 9.0 branch with mergify docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doc: Logstash breaking changes for 9.0 (WIP)
2 participants
@robbavey @karenzone