Update rexml #17441
Draft
Update rexml #17441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsel
force-pushed
the
fix/upgrade_rexml
branch
from
c4db39a to
59eb521
Compare
💚 Build Succeeded
History
cc @andsel |
andsel
commented
Mar 31, 2025
| @@ -112,7 +112,7 @@ def configure_proxy | |||
| if !proxies.empty? | |||
| FileUtils.mkdir_p(SETTINGS_TARGET) | |||
| target = ::File.join(SETTINGS_TARGET, "settings.xml") | |||
| template = ::File.read(SETTINGS_TEMPLATE) | |||
| template = ::File.read(SETTINGS_TEMPLATE).gsub(/(^#.*$)/, '') # removes comment lines starting with # | |||
There was a problem hiding this comment.
Note for reviewer
With new rexml version, the comment lines are not anymore accepted in erb file. The alternative to this change, is replicate what was done on main, remove the comment header section in file lib/pluginmanager/settings.xml.erb https://github.com/elastic/logstash/blob/7.17/lib/pluginmanager/settings.xml.erb#L1-L16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test the removal of ERB comment lines
SPEC_OPTS="-fd -P spec/unit/plugin_manager/proxy_support_spec.rb" ./gradlew :logstash-core:rubyTests --tests org.logstash.RSpecTests --rerun-tasksExhaustive tests:
https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1624