chmod BUILD_METADATA_FILE to allow global read permissions #17546
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
Allow global read permissions on BUILD_METADATA_FILE
What does this PR do?
This PR allows for global read permissions on BUILD_METADATA_FILE (build.rb). This file is created by Ruby's
Tempfile.new
which is hardwired to set permissions to0600
on all temporary files.If a logstash user builds logstash and then attempts to run for example the Docker version as another system user the run will fail as only the build user has permission to read
build.rb
once it is packaged as owned by that build user with perms0600
.Why is it important/What is the impact to the user?
This PR fixes #14836 which contains a complete bug report from a user experiencing this issue. The relevant excerpt is:
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files (and/or docker env variables)- [ ] I have added tests that prove my fix is effective or that my feature worksAuthor's Checklist
0644
How to test this PR locally
Build all logstash packages and successfully install one or run the Docker image
Related issues
Use cases