Skip to content

Release notes for 8.17.5 #17550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025
Merged

Release notes for 8.17.5 #17550

merged 3 commits into from
Apr 14, 2025

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@donoghuc donoghuc marked this pull request as ready for review April 11, 2025 22:15
@donoghuc donoghuc requested review from karenzone and mashhurs April 11, 2025 22:15
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -3302,4 +3363,4 @@ We have added another flag to the Benchmark CLI to allow passing a data file wit
This feature allows users to run the Benchmark CLI in a custom test case with a custom config and a custom dataset. https://github.com/elastic/logstash/pull/12437[#12437]

==== Plugin releases
Plugins align with release 7.14.0
Plugins align with release 7.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 what is this 7.14.0? Shouldn't be 8.0.0 (initial 8)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is at the very bottom of the 8.x release notes file, and aligns with Logstash 8.0.0-alpha release notes.


==== Plugins

*Elasticsearch Filter - 3.17.1*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left suggestion and notes inline. Otherwise, LGTM!
Thanks for your work on this, @donoghuc

Please merge by end of day on the day before the release.

@@ -3302,4 +3363,4 @@ We have added another flag to the Benchmark CLI to allow passing a data file wit
This feature allows users to run the Benchmark CLI in a custom test case with a custom config and a custom dataset. https://github.com/elastic/logstash/pull/12437[#12437]

==== Plugin releases
Plugins align with release 7.14.0
Plugins align with release 7.14.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is at the very bottom of the 8.x release notes file, and aligns with Logstash 8.0.0-alpha release notes.

[[logstash-8-17-5]]
=== Logstash 8.17.5 Release Notes

* The `SettingString` setting is now correctly non-nullable and `SettingNullableString` is nullable. https://github.com/elastic/logstash/pull/17522[#17522]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check out "Release notes" section in the PR. The developers put suggestions for user-focused release notes there, and they're usually more informative than the PR title.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i had seen that but it didnt quite make sense to me so I tried to make it a bit more explicit. Would you prefer that just gets copied over?

Ensures that SettingString is correctly non-nullable and SettingNullableString is nullable. https://github.com/elastic/logstash/pull/17522[#17522]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donoghuc You make the call. I trust your judgement. :-)

Co-authored-by: Karen Metts <[email protected]>
@donoghuc donoghuc merged commit 16ee40c into 8.17 Apr 14, 2025
6 checks passed
@donoghuc donoghuc deleted the update_release_notes_1744393509 branch April 14, 2025 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants