[ML] Fix compiler warnings across the codebase

[edsavage]

Summary

• Reduces Clang warnings from ~2,500 to 86 (all remaining are -Wunsafe-buffer-usage, which require a std::span migration and are out of scope here).
• Adds three warning suppressions to clang.cmake:
  • -Wno-switch-default (174 warnings) — conflicts with the more useful -Wswitch-enum; adding default: to exhaustive enum switches would suppress missing-case detection when new enum values are added.
  • -Wno-nrvo (19 warnings) — purely informational C++23 diagnostic about NRVO eligibility.
  • -Wno-missing-noreturn (5 warnings) — all remaining cases are lambdas where [[noreturn]] cannot be applied pre-C++23.
• Fixes 80 code warnings across 59 files:
  • Removes 37 unused const variables (dead code from state serialisation refactors).
  • Removes 2 unused functions (calibrationExperiment, dataGenerator in tests) and 2 unused-but-set variables.
  • Fixes 9 shadow warnings by renaming inner variables.
  • Fixes 8 implicit int-to-float conversions with explicit static_cast<double>().
  • Fixes 2 tautological-compare logic bugs where !(p >= 0.0 || p <= 1.0) was always false — corrected to !(p >= 0.0 && p <= 1.0).
  • Removes 2 redundant default: cases in exhaustive enum switches.
  • Fixes 1 pessimizing-move, 1 range-loop-bind-reference, 1 sign-compare, 1 shorten-64-to-32, 1 CTAD issue.
  • Removes unnecessary virtual from method in final class.
  • Adds [[noreturn]] to named function throws().

Test plan

• CI passes on all platforms (Linux x86_64, Linux aarch64, macOS aarch64, Windows x86_64)
• clang-format check passes
• Verify no behavioural changes other than the tautological-compare bug fixes

Made with Cursor

[prodsecmachine]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.