[ML] Run allowlist validation in PyTorch edge pipeline#2989
Open
edsavage wants to merge 1 commit intoelastic:mainfrom
Open
[ML] Run allowlist validation in PyTorch edge pipeline#2989edsavage wants to merge 1 commit intoelastic:mainfrom
edsavage wants to merge 1 commit intoelastic:mainfrom
Conversation
When the PyTorch edge build triggers a test run, also invoke the Python-based allowlist validation (validate_allowlist.py) which traces live HuggingFace models with the new PyTorch version and checks every op against ALLOWED_OPERATIONS / FORBIDDEN_OPERATIONS. This ensures that if a PyTorch upgrade introduces new TorchScript operations for any supported model architecture, the pipeline fails with a clear message before the change reaches a release. Made-with: Cursor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ml-cpp-build-pytorch) triggers a test run, also invoke the Python-based allowlist validation (validate_allowlist.py) which traces 22 live HuggingFace models plus 3 local ES integration test.ptfiles with the new PyTorch version.ALLOWED_OPERATIONS/FORBIDDEN_OPERATIONSinCSupportedOperations.ccand fails hard if any model produces an unrecognised or forbidden op.GITHUB_PR_COMMENT_VAR_ACTION=run_pytorch_tests.This closes the gap identified in #2936 where the C++ golden-file test (
testAllowlistCoversReferenceModels) catches allowlist drift but cannot detect new ops introduced by a PyTorch upgrade since the golden file was generated with the old version.Test plan
ALLOWED_OPERATIONS, the validation fails with a clear messageMade with Cursor