Conversation
There was a problem hiding this comment.
Pull Request Overview
Purpose: Update the test workflow to use a different fork/version of the free-disk-space action, presumably to improve build performance per referenced upstream PR.
- Replaces jlumbroso/free-disk-space with Jayllyz/free-disk-space pinned to a commit.
- Adds a comment referencing the upstream PR and annotates a version label (# v1.3.1).
| - uses: actions/checkout@v5 | ||
| - name: Free Disk Space (Ubuntu) | ||
| uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be | ||
| # See https://github.com/jlumbroso/free-disk-space/pull/26 |
There was a problem hiding this comment.
[nitpick] The inline comment references a PR in the original jlumbroso repository, but the workflow now uses a different repository (Jayllyz). Clarify that this is a fork used for the changes in that PR (e.g., add 'Using fork with PR #26 changes until merged') to avoid confusion for future maintainers.
| # See https://github.com/jlumbroso/free-disk-space/pull/26 | |
| # Using fork (Jayllyz/free-disk-space) with PR #26 changes until merged: | |
| # https://github.com/jlumbroso/free-disk-space/pull/26 |
| - name: Free Disk Space (Ubuntu) | ||
| uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be | ||
| # See https://github.com/jlumbroso/free-disk-space/pull/26 | ||
| uses: Jayllyz/free-disk-space@3bda29d61d3f1fa7bf46c5a9a11f22dd20af07c9 # v1.3.1 |
There was a problem hiding this comment.
[nitpick] The comment '# v1.3.1' may drift from the pinned commit if the tag later points elsewhere or the fork diverges. To keep provenance clear, either reference the tag explicitly (if trusted) as @v1.3.1, or augment the comment with the fork's release URL or upstream commit hash to reduce ambiguity.
| uses: Jayllyz/free-disk-space@3bda29d61d3f1fa7bf46c5a9a11f22dd20af07c9 # v1.3.1 | |
| uses: Jayllyz/free-disk-space@3bda29d61d3f1fa7bf46c5a9a11f22dd20af07c9 # v1.3.1 (https://github.com/Jayllyz/free-disk-space/releases/tag/v1.3.1) |
See jlumbroso/free-disk-space#26