Update Logstash report to include batch's byte_size p100 and lifetime#989
Open
andsel wants to merge 2 commits intoelastic:mainfrom
Open
Update Logstash report to include batch's byte_size p100 and lifetime#989andsel wants to merge 2 commits intoelastic:mainfrom
andsel wants to merge 2 commits intoelastic:mainfrom
Conversation
…e max percentile just for batch's byte_size. Furthermore, adds the lifetime window for all batch relates metrics (byte_size and event_count)
pickypg
approved these changes
Apr 21, 2026
Member
pickypg
left a comment
pickypg
left a comment
There was a problem hiding this comment.
This looks good, but I think you can / should merge these functions to avoid duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the report generated when taking Logstash diags to include the max percentile just for batch's byte_size. Furthermore, adds the lifetime window for all batch relates metrics (byte_size and event_count).
Checklist
What the PR does?
Updates the HTML template file used to generate the report bundled with Logstash diagnostic to add the lifetime window column for all percentiles of batch structure metric.
In the same table add a new percentile, p100 or max which is available only for batch's byte_size metric.
Following a set of snapshots of the updated section: