-
Notifications
You must be signed in to change notification settings - Fork 121
Add write-only password support to elasticsearch_security_user resource #1419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/add-write-only-argument-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+602
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: tobio <[email protected]>
Co-authored-by: tobio <[email protected]>
…able Co-authored-by: tobio <[email protected]>
Copilot
AI
changed the title
[WIP] Add write-only argument support for elasticsearch_security_user
Add write-only password support to elasticsearch_security_user resource
Nov 5, 2025
Copilot finished work on behalf of
tobio
November 5, 2025 03:46
…ons, fix password_wo version logic Co-authored-by: tobio <[email protected]>
Co-authored-by: tobio <[email protected]>
Copilot finished work on behalf of
tobio
November 5, 2025 06:21
Co-authored-by: tobio <[email protected]>
Copilot finished work on behalf of
tobio
November 5, 2025 07:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration Plan: elasticsearch_security_user to Plugin Framework + Write-Only Attributes
Phase 1: Migrate from SDKv2 to Plugin Framework ✅
internal/elasticsearch/security/user/system_userpatternuser_test.gotouser/acc_test.goTestAccResourceSecurityUserFromSDKtest for seamless migrationprovider/plugin_framework.goprovider/provider.gouser_shared.gofor data source compatibilityuser.goanduser_test.gofilesPhase 2: Add Write-Only Attribute Support ✅
password_woandpassword_wo_versionattributes to schemapassword_woandpassword_wo_versionTestAccResourceSecurityUserWithPasswordWoacceptance testPhase 3: Address PR Review Feedback ✅
ConflictsWith,PreferWriteOnlyAttribute, andAlsoRequiresvalidatorsSizeAtLeast(1)validator for rolesPutUserandDeleteUserto return Framework diagnostics directlypassword_wofrom config instead of plan (per Terraform write-only guidelines)Summary
Successfully migrated
elasticsearch_security_userresource from Terraform SDKv2 to Plugin Framework and added write-only password support for ephemeral resources.Key Features:
password_woandpassword_wo_versionattributes allow using ephemeral resources (like Vault secrets) without storing passwords in statePutUserandDeleteUserfunctionspassword_wofrom config rather than planTesting:
Original prompt
elasticsearch_security_user#1295💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.