Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api-conventions.asciidoc #13

Open
wants to merge 1 commit into
base: cn
Choose a base branch
from
Open

api-conventions.asciidoc #13

wants to merge 1 commit into from

Conversation

autumnbz
Copy link

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS that we support?
  • If you are submitting this code for a class then read our policy for that.

@autumnbz autumnbz changed the title api-conventions.asciidoc 第七章翻译初版 chapter/chapter7/api-conventions.asciidoc 第七章翻译初版 May 27, 2018
@Littlesqx Littlesqx self-requested a review September 30, 2018 08:58
Littlesqx
Littlesqx reviewed Sep 30, 2018
View reviewed changes
docs/reference/api-conventions.asciidoc

[[date-math-index-names]]
== Date math support in index names
== Date math 索引名称支持
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

前面多了空格

docs/reference/api-conventions.asciidoc

[float]
=== Pretty Results
=== Pretty 结果
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

优雅的结果？

docs/reference/api-conventions.asciidoc

Rest parameters (when using HTTP, map to HTTP URL parameters) follow the
convention of using underscore casing.
Rest 参数 （当使用 HTTP，映射为 HTTP URL 参数）(when using HTTP, map to HTTP URL parameters）遵循使用下划线框的约定。
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest 参数后应该不需要空格

@howardhuanghua howardhuanghua changed the title chapter/chapter7/api-conventions.asciidoc 第七章翻译初版 api-conventions.asciidoc Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Littlesqx Littlesqx Littlesqx left review comments

Assignees
No one assigned
Labels
to be review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@autumnbz @Littlesqx