Conversation
…ctions annotated with `#[builder]` This isn't a complete fix. Unfortunately, the parameters now get assigned the semantic token type of `variable` after this fix, which is only slightly better than `struct` semantic token type that they were assigned before this fix. Created an issue in rust-analyzer repository to track this problem: rust-lang/rust-analyzer#19556.
Veetaha
force-pushed
the
fix/smallfix-ra-syntax-highlighting-for-fn-params
branch
from
abe3f7c to
38bf02e
Compare
anelson
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a complete fix. Unfortunately, the parameters are now getting assigned the semantic token type of
variableinstead ofparameterafter this fix, which is only slightly better thanstructsemantic token type that they were assigned before this fix.This problem became worse after #269 which added unconditional two-level macro expansion, after which I noticed this problem, although a little later after that patch was released.
Created an issue in rust-analyzer repository to track this problem: rust-lang/rust-analyzer#19556.