Skip to content

Conversation

@rorito
Copy link
Contributor

@rorito rorito commented Jun 16, 2015

Hi Patrick, we've been using django-sendgrid-events on https://www.tribute.co with good success. One thing we recently added in our fork was a quick check for some settings vars to enable background processing via celery workers. We use Heroku, so it frees up our web dynos for quicker request/response cycles and performs the work on a background worker. Anyways, here's a PR if you're interested : )

aspd172 and others added 2 commits June 11, 2015 18:15
- updated to use process the sendgrid events on celery if the settings variable
  SENDGRID_BACKGROUND_PROCESSING is set to True
@paltman
Copy link
Contributor

paltman commented Aug 3, 2015

I don't mind this at all, but don't want to require dependency on celery, which this change does. I think it would be best to implement the process_batch method as a hookset (example hookset) so you could override it at the project level to perform whatever queuing/backgrounding you wanted to do whether it was celery or some other background processor.

aspd172 and others added 6 commits August 9, 2015 13:24
- make sure the result is always json-serializable if the process is run
  in the background
#1211 sendgrid Events not JSON serializable for celery
- removed hard dependency on celery
- allowed the option to define a custom handler for sendgrid events
@rorito
Copy link
Contributor Author

rorito commented Aug 12, 2015

@paltman Our developer Abel implemented the hookset refactor you were talking about and I added some instructions in the README about how to configure Celery support in your project. Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants