fix(deps): restore production dependency safety - #135
Draft
rksharma-owg wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This follow-up to #119 restores the production dependency safety work in the repository:
@modelcontextprotocol/sdk,@hono/node-server,express,body-parser, andfast-uri;Errortype required by the refreshed dependency graph under strict TypeScript checking.The Node floor is intentional: the existing resolved
undici@8.8.0already declares>=22.19.0, and the suite reproduces runtime failures on Node 20. The new declaration makes the supported runtime honest rather than silently accepting an incompatible installation.User impact
npm audit --omit=devis clean, while the documented runtime now matches the dependency tree actually exercised by CI and local tests. There are no application behavior or public API changes.Validation
npm run typecheck,npm test, andnpm run build --silentall pass.npm run lintpasses with 0 errors (133 existing warnings),npm run typecheckpasses, and all 675 tests pass.npm run test:coveragepasses with 100% coverage on gated files.npm run doctorreports PASS (30/33 checks); the three warnings are optional local tools/services not present (semgrep,promptfoo, and the local API).npm run verify-claimspasses 27/27.npm run test:no-fitting,npm run test:no-self-fitting, andnpm run test:gatepass.npm run prompt:auditpasses when invoked from a no-space symlink; its direct invocation in this workspace exposes a pre-existing URL-path decoding issue because the parent directory contains a space.npm run smokereports 4 pass, 0 fail, and 4 expected skips because no local API or live LLM provider was running.npm audit --omit=dev --audit-level=moderatereports 0 vulnerabilities.Contribution Receipt
local_labnot_applicableloopbackfor local runtime checks; npm registry access for dependency installation and audit metadata.static_test,local_onlynot_applicable; agent runtimeCodex; harnessesvitest, project verification scripts, TypeScript, and npm audit; tool accesslocal_only; target classlocal_lab; run modesingle_agent.npm run lint-> pass (0 errors; 133 existing warnings)npm run typecheck-> passnpm test-> pass (675/675)npm run build --silent-> passnpm run test:coverage-> passnpm run doctor-> pass with 3 optional-tool/service warningsnpm run verify-claims-> pass (27/27)npm run test:no-fitting-> passnpm run test:no-self-fitting-> passnpm run test:gate-> passnpm run prompt:audit-> pass via a no-space symlinknpm run smoke-> pass (4 passed, 4 environment-dependent skips)npm audit --omit=dev --audit-level=moderate-> pass (0 vulnerabilities)npx --yes -p node@22.19.0 -c 'node --version; npm run typecheck; npm test; npm run build --silent'-> passpackage-lock.jsonrecords the resolved dependency graph; test output was reviewed locally and is not committed.undici@8.8.0's engine requirement plus a passing minimum-version validation run.brace-expansionadvisories in the ESLint toolchain. Resolving those currently requires an incompatible ESLint major upgrade, so this PR does not force it into the production-safety patch.