Bump libpg_query from 15-latest to 17-latest #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was removed in postgres/postgres@a676386. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@40c24bf, but should actually not be present in the raw parser output. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@c9d5298, but should actually not be present in the raw parser output. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@45b9805 and should render as CURRENT_ROLE. Signed-off-by: Wolfgang Walther <[email protected]>
This was changed in postgres/postgres@cc35d89. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@bbe0a81 and later changed in postgres/postgres@e6241d8. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@a4d75c8, but should actually not be present in the raw parser output. Signed-off-by: Wolfgang Walther <[email protected]>
This was added in postgres/postgres@71f4c8c. Signed-off-by: Wolfgang Walther <[email protected]>
This was changed in postgres/postgres@b5913f6. Signed-off-by: Wolfgang Walther <[email protected]>
…ROP_PUBLICATION to deparser Those were added in postgres/postgres@82ed774. The same commit also changed ALTER_SUBSCRIPTION_PUBLICATION to ALTER_SUBSCRIPTION_SET_PUBLICATION. Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
Signed-off-by: Wolfgang Walther <[email protected]>
* Fix cursor quoting in FetchStmt Regression tests updated to test all cursor related statement with a name that requires quoting. * Test quoting in `deparse_tests.c` --------- Co-authored-by: msepga <[email protected]>
We've removed them in previous refactorings, but didn't clean up the list.
This called the general deparseExpr function (a_expr), but should actually have called the deparseCExpr function (since AexprConst is part of c_expr). However we currently do not handle TypeCast nodes inside deparseCExpr, causing it to add parenthesis unnecessary. To mitigate, add a dedicated function for this.
This allows us to handle keyword-style FuncCalls correctly in deparseFuncCall, as will be done in a subsequent commit. Note that the safe choice here is to set the context to NONE, which intends to add parenthesis in places where a_expr is not allowed (b_expr or c_expr can be turned into an a_expr by being wrapped in parens)
This fixes a correctness issue where the deparsed SQL is not parsable, since the table DEFAULT expression is a b_expr, not an a_expr.
Note that the deparseAExpr function (used for deparsing A_Expr nodes) can be called from both a_expr and b_expr contexts, but we previously always passed NONE as the context. Besides now passing down the context, the function also used to add outer parenthesis to AEXPR_OP calls. This appears unnecessary (b_expr allows operator expressions without wrapping parenthesis) and was not utilized in practice, so remove that to avoid extra parenthesis.
Co-authored-by: Tyler Gannon <[email protected]>
This pulls in the strchrnul compatibility patch directly from upstream, instead of applying it manually. Other updates since 17.0 are minor and should not affect parser behaviour.
This unintentionally got removed when re-running the extract_source logic on macOS 15.4, which no longer requires LOCALE_T_IN_XLOCALE to be set.
This makes it clear which parts of the repository are under the Postgres license.
…ion number in the related test.
Closed
Contributor
|
Thanks, we were about to do it ourselves! |
Contributor
|
I want the next upgrade to be cleaner, so I'll merge in a different version preserving a git subtree addition merge commit (and using squashed history) - it should make further upgrades possible with just a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the libpg_query subtree with 17-latest, rebuilt the protobuf bindings and bumped the version number in the test so all tests pass.